Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recommended extensions and settings #1709

Merged
merged 2 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ charset = utf-8
[*.{json,yml}]
indent_size = 2

[*.neon]
[*.{neon,neon.dist}]
indent_style = tab

[Makefile]
Expand Down
9 changes: 4 additions & 5 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
{
"recommendations": [
"felixfbecker.php-intellisense",
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
"ikappas.phpcs",
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
"emallin.phpunit",
"EditorConfig.editorconfig",
"sophisticode.php-formatter"
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
"EditorConfig.editorconfig", // standard
"bmewburn.vscode-intelephense-client", // intellisense
"emallin.phpunit", // nice unit-testing runners
"SanderRonde.phpstan-vscode" // linting
]
}
11 changes: 5 additions & 6 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@

"editor.renderWhitespace": "all",

"[php]": {
"editor.defaultFormatter": "bmewburn.vscode-intelephense-client"
},

// Formatting
"editor.formatOnSave": true,
"phpformatter.composer": true,
"phpformatter.arguments": [""],

// Linting
"phpcs.enable": true,
"phpcs.standard": "PSR2"
"intelephense.format.braces": "psr12"
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
}
4 changes: 4 additions & 0 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@ parameters:
- '#Unsafe usage of new static\(\).#'

reportUnmatchedIgnoredErrors: false

paths:
- lib
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
- tests
Loading