Generate synthetic fixtures for nullable types when expansions are requested #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #445 is caused by a crash when you try to expand a nullable attribute:
This is because
generateSyntheticFixtures
defaults to returningnil
if the property is nullable. However, this poses an issue when we want to expand that nullable field.This PR updates
generateSyntheticFixtures
to check expansions and generate non-nil
fixtures for nullable properties if they're being expanded.