Add onBehalfOf type to PaymentRequest #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinalong-stripe
requested changes
Apr 4, 2024
| @@ -3184,6 +3184,13 @@ const paymentRequest: PaymentRequest = stripe.paymentRequest({ | |||
| }, | |||
| }); | |||
|
|
|||
| const paymentRequestOBO: PaymentRequest = stripe.paymentRequest({ | |||
| country: 'US', | |||
| currency: 'usd', | |||
There was a problem hiding this comment.
Can we also add a test in invalid.ts that checks that you cannot update onBehalfOf?
awalker-stripe
force-pushed
the
awalker/pr-obo
branch
from
8e432a2
to
8a9f1e7
Compare
martinalong-stripe
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Adds
onBehalfOfas a valid parameter forPaymentRequestsTesting & documentation
Unit test