Beta: RawApiRequest #1717
Merged
Beta: RawApiRequest #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing method overloads
Change StripeResponseGetter to take a single APIRequest object
richardm-stripe
force-pushed
the
richardm-beta-apirequest
branch
from
b71d2ad to
32d53e1
Compare
|
Compatibility change: |
richardm-stripe
requested review from
a team,
helenye-stripe and
anniel-stripe
and removed request for
a team
anniel-stripe
approved these changes
Jan 10, 2024
Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>
Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes a merge of master into beta.
Review the last couple commits:
Like #1702 but extends the approach to
StripeResponseGetter.rawRequest(RawApiRequest request).Approach
I have chosen to introduce
RawApiRequestas a subclass ofBaseApiRequestrather than try and add a fieldrawContentintoApiRequestand giveApiRequestmultiple constructors. This is consistent with howrawRequestalready takesRawRequestOptionswhich is a subclass ofRequestOptions.Changelog
StripeResponseGetter.rawRequest(...)-- new usage isStripeResponseGetter.rawRequest(new RawApiRequest(...))