Refactor VerticalPaymentMethodListSelection -> RowButton.Type #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han a map of RowButton -> Type
yuki-stripe
force-pushed
the
yuki/embedded-update-form-pm-row-pt-2
branch
from
c5fcad7 to
afa36d4
Compare
StripeCore- public func caseInsensitiveContains(_ other: Swift.String) -> Swift.Bool
- @discardableResult
- public mutating func remove(_ element: Element) -> Element?If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
| @@ -28,4 +28,11 @@ extension Array where Element: Equatable { | |||
| guard let index = firstIndex(of: element) else { return nil } | |||
| return remove(at: index) | |||
| } | |||
|
|
|||
| @discardableResult public mutating func replace(_ element: Element, with newElement: Element) -> Element? { | |||
There was a problem hiding this comment.
Looks like CI flagged this, but should be behind SPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This renames VerticalPaymentMethodListSelection to RowButton.Type and adds a
typeproperty to RowButton.Motivation
There was potential value in having RowButton be agnostic to whether it was a saved PM / new PM / Apple Pay / Link, in particular if we ever wanted to move it to StripeCore. But it's too useful for RowButton to hold onto its type and I don't think it's worse off for it. We can simplify
EmbeddedPaymentMethodsViewa lot with this change.Vertical mode could also benefit from this change but I'll leave that for another PR.
Testing
Existing tests, no new behavior
Changelog
Not user facing