Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe pod does not compile on Xcode 11.4 #1525

Closed
stephengilroy-grx opened this issue Mar 24, 2020 · 9 comments
Closed

Stripe pod does not compile on Xcode 11.4 #1525

stephengilroy-grx opened this issue Mar 24, 2020 · 9 comments
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@stephengilroy-grx
Copy link

Summary

After just recently updating to the new Xcode 11.4 I am unable to build my project withe Stripe SDK pod. Compiler error given is:
Incompatible block pointer types sending '__strong STPAPIResponseBlock _Nonnull' (aka 'void (^__strong)(ResponseType _Nullable __strong, NSHTTPURLResponse * _Nullable __strong, NSError * _Nullable __strong)') to parameter of type 'void (^ _Nonnull)(STPSource * _Nullable __strong, NSHTTPURLResponse * _Nullable __strong, NSError * _Nullable __strong)'

Code to reproduce

I was able to repro with a newly created empty project. Just run pod init add the latest stripe pod and try to build.

iOS version

13.4

Installation method

Cocoapods

SDK version

19.0.0 (also observed this behavior on 18.x versions)

Other information

I've tried everything imaginable: nuking pods, restarting my computer, deleting derived data, etc. As soon as I downgrade to 11.3.1 I am able to successfully build again.

From the error response above it seems this might be related to ObjC generics?
@bryanbartow
Copy link

Looks like this might be fixed in #1524

@stephengilroy-grx
Copy link
Author

#1526 was just merged in so I believe this should be resolved soon 🤞

@yuki-stripe yuki-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Mar 25, 2020
@yuki-stripe
Copy link
Collaborator

Thanks for the report, we're working on releasing a new version that fixes this now.

@csabol-stripe
Copy link
Contributor

We've just published a release with this fix https://github.com/stripe/stripe-ios/releases/tag/v19.0.1
It should also be live on cocoapods

@prgorasiya
Copy link

My app still supports iOS 9.
Therefore I have to use V17.0.2 and thats throwing issues with Xcode 11.4
Any way to fix this?

@mhergon
Copy link

mhergon commented Mar 25, 2020

My app still supports iOS 9.
Therefore I have to use V17.0.2 and thats throwing issues with Xcode 11.4
Any way to fix this?

Same here!

@mikedizon
Copy link

Issued a PR for v14.0.0/v14.0.1

#1534

@davidme-stripe
Copy link
Contributor

We've released v14.0.1, v15.0.2, v17.0.3, and v19.0.1 to Cocoapods with fixes for this issue.

We think this should cover all current versions without additional migration work. Please let us know if you're unable to update to one of these versions.

This was referenced Mar 25, 2020
Closed
Closed
Merged
@jlariza jlariza mentioned this issue Mar 30, 2020
Closed
@mitchellbutler mitchellbutler mentioned this issue Apr 2, 2020
Closed
@lillogoal lillogoal mentioned this issue Apr 7, 2020
Closed
ergunkocak added a commit to ergunkocak/eidolon that referenced this issue May 12, 2020
@ergunkocak
xcode 11.4 compatibility update
52532fd 
stripe/stripe-ios#1525
@ergunkocak ergunkocak mentioned this issue May 12, 2020
Merged
@sjchmiela sjchmiela mentioned this issue Jun 1, 2020
Merged
sjchmiela added a commit to expo/expo that referenced this issue Jun 1, 2020
@sjchmiela
[expo-payments-stripe] Upgrade Stripe dependency to fix Xcode 11.4 co…
3d1fb0e 
…mpat (#8594)

# Why

- Fixes #7621.
- Stripe 13 is incompatible with Xcode 11.4.
- We've been slow to update the package.

# How

- Updated the dependency version to `~> 14.0.1` fixing the issue as per stripe/stripe-ios#1525 (comment). The 13 ➡️ 14 upgrade should not break anything, I have verified that we don't use any of the changed classes described [in changelog](https://github.com/stripe/stripe-ios/blob/master/CHANGELOG.md#1400-2018-11-14).
- Added the ability to set a completely custom version of Stripe in order to let people upgrade to newer versions without using `patch-package` etc. We already do this in eg. `expo-image`.

# Test Plan

Temporarily I have removed the `expo-payments-stripe` package from the list of `excludedUnimodules` in `bare-expo`. I have verified that after applying these changes the application runs successfully.
@davidme-stripe davidme-stripe mentioned this issue Aug 31, 2020
Closed
ramont-stripe added a commit that referenced this issue Oct 24, 2022
@ramont-stripe
[Link] Remove CardDetailsEditView (#1525)
6c6e77a 
* Add LinkCardEditElement

* Remove CardDetailsEditView

* Refactor to use CardExpiryDate

* Set default countries

* Remove default label

* Hide checkbox for default PM

* Re-add label

* Add snapshot tests

* Cleanup

* Fix animation glitch

* Properly the delegate

* Remove CardDetailsEditView.swift

* Fix tests

* Cleanup

* Add assert message

* Add TODO

* End editing when submitting the form

* Remove extra constraints

* Rename expiry date element var

* Fix test

* Remove hardcoded years

* Rename var

* Add clarifying comment
@Dual-Tech
Copy link

what is the latest version that still accomdates the didcreatetoken method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mikedizon @mhergon @bryanbartow @prgorasiya @csabol-stripe @yuki-stripe @davidme-stripe @stephengilroy-grx @Dual-Tech