[Link] Fix accessibility description label for saved bank account det…

…ails (#1534) * Restore and fix label specific for bank accounts * Update strings * Rename var
stripe · Oct 24, 2022 · d0e9b14 · d0e9b14
1 parent 79f19ff
commit d0e9b14
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/Stripe/STPPaymentMethod+BasicUI.swift b/Stripe/STPPaymentMethod+BasicUI.swift
@@ -47,7 +47,7 @@ extension STPPaymentMethod: STPPaymentOption {
             }
         case .USBankAccount:
             if let usBankAccount = usBankAccount {
-                return String(format: String.Localized.card_brand_ending_in_last_4, usBankAccount.bankName, usBankAccount.last4)
+                return String(format: String.Localized.bank_name_account_ending_in_last_4, usBankAccount.bankName, usBankAccount.last4)
             } else {
                 fallthrough
             }

diff --git a/StripePaymentSheet/StripePaymentSheet/Categories/STPPaymentMethod+PaymentSheet.swift b/StripePaymentSheet/StripePaymentSheet/Categories/STPPaymentMethod+PaymentSheet.swift
@@ -41,8 +41,7 @@ extension STPPaymentMethod {
                 guard let usBankAccount = self.usBankAccount else {
                     return nil
                 }
-                return String(format: String.Localized.card_brand_ending_in_last_4, usBankAccount.bankName, usBankAccount.last4)
-
+                return String(format: String.Localized.bank_name_account_ending_in_last_4, usBankAccount.bankName, usBankAccount.last4)
             default:
                 return nil
             }

diff --git a/StripePaymentSheet/StripePaymentSheet/Internal/API Bindings/Link/PaymentDetails.swift b/StripePaymentSheet/StripePaymentSheet/Internal/API Bindings/Link/PaymentDetails.swift
@@ -347,7 +347,7 @@ extension ConsumerPaymentDetails {
         case .bankAccount(let bank):
             let digits = bank.last4.map({ String($0) }).joined(separator: ", ")
             return String(
-                format: String.Localized.card_brand_ending_in_last_4,
+                format: String.Localized.bank_name_account_ending_in_last_4,
                 bank.name,
                 digits
             )

diff --git a/StripePaymentsUI/StripePaymentsUI/Helpers/String+Localized.swift b/StripePaymentsUI/StripePaymentsUI/Helpers/String+Localized.swift
@@ -25,6 +25,13 @@ extension String.Localized {
             "Details of a saved card. '{card brand} ending in {last 4}' e.g. 'VISA ending in 4242'"
         )
     }
+
+    @_spi(STP) public static var bank_name_account_ending_in_last_4: String {
+        STPLocalizedString(
+            "%1$@ account ending in %2$@",
+            "Details of a saved bank account. '{bank name} account ending in {last 4}' e.g. 'Chase account ending in 4242'"
+        )
+    }
 
     @_spi(STP) public static var apple_pay: String {
         STPLocalizedString("Apple Pay", "Text for Apple Pay payment method")

diff --git a/StripePaymentsUI/StripePaymentsUI/Resources/Localizations/en.lproj/Localizable.strings b/StripePaymentsUI/StripePaymentsUI/Resources/Localizations/en.lproj/Localizable.strings
@@ -1,3 +1,6 @@
+/* Details of a saved bank account. '{bank name} account ending in {last 4}' e.g. 'Chase account ending in 4242' */
+"%1$@ account ending in %2$@" = "%1$@ account ending in %2$@";
+
 /* Details of a saved card. '{card brand} ending in {last 4}' e.g. 'VISA ending in 4242' */
 "%1$@ ending in %2$@" = "%1$@ ending in %2$@";