Fix protomodule.NewMessage handling of protobuf field presence #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running into an issue where going back and forth between protos and JSON is losing information.
Within the protobuf ecosystem, it's common to use
google.protobuf.Value
(https://protobuf.dev/reference/protobuf/google.protobuf/#value) to represent JSON types.In such scenarios, what should
return? Today, it returns an empty protobuf, with no information about the key
"foo"
.The underlying issue here is tracking field presence. I've left a few comments and links to the reference (here).
There was actually a TODO left in the code about this. In an attempt to minimize the potential impact, I've left the existing
isFieldSet
check and adding a specific carve-out for fields with explicit presence. If desired, I can remove that too — as noted in the previous TODO,Range
should handle this automatically, and my testing bears this out.