-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Terminal SDK to 3.1.0 #47
Conversation
Also remove `TerminalEventListener` dependency on `MainViewModel`, this was causing a memory leak.
app/src/main/java/com/stripe/aod/sampleapp/model/MainViewModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: chr-stripe <108023228+chr-stripe@users.noreply.github.com>
app/build.gradle.kts
Outdated
|
||
defaultConfig { | ||
applicationId = "com.stripe.aod.sampleapp" | ||
minSdk = 28 | ||
targetSdk = 33 | ||
targetSdk = 34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, was AoD verified to work on API 34 + targetSdk 34
? We have had issues with some other reader types when using this: stripe/stripe-terminal-android#387
I don't believe any of the things in that issue affecting BT/USB/TTPA discovery + connection should apply to handoff, but just want to make sure this was manually verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I reverted this for now. Will test and bump independently.
Hello @mshafrir-stripe I am sorry to contact here, but it seems there is no way to create a github issue on that repo. I get the following error with my S700 DevKit, on that line:
The error message seems to indicate that If that is the case, could it be possible to enable Thank for your help, Bernard. |
Please work your sales representative to enable Apps on Devices for your account. |
Also remove
TerminalEventListener
dependency onMainViewModel
, this was causing a memory leak.How has this been tested?
Reproducible test instructions
Manually verified by running through a transaction