Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terminal SDK to 3.1.0 #47

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Update Terminal SDK to 3.1.0 #47

merged 4 commits into from
Oct 23, 2023

Conversation

mshafrir-stripe
Copy link
Collaborator

Also remove TerminalEventListener dependency on MainViewModel, this was causing a memory leak.

How has this been tested?

  • Automated
  • Manual

Reproducible test instructions

Manually verified by running through a transaction

Also remove `TerminalEventListener` dependency on `MainViewModel`,
this was causing a memory leak.
Co-authored-by: chr-stripe <108023228+chr-stripe@users.noreply.github.com>
@mshafrir-stripe mshafrir-stripe changed the title Update Terminal SDK to 3.0.0 Update Terminal SDK to 3.1.0 Oct 23, 2023
chr-stripe
chr-stripe previously approved these changes Oct 23, 2023

defaultConfig {
applicationId = "com.stripe.aod.sampleapp"
minSdk = 28
targetSdk = 33
targetSdk = 34
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, was AoD verified to work on API 34 + targetSdk 34? We have had issues with some other reader types when using this: stripe/stripe-terminal-android#387

I don't believe any of the things in that issue affecting BT/USB/TTPA discovery + connection should apply to handoff, but just want to make sure this was manually verified.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I reverted this for now. Will test and bump independently.

@mshafrir-stripe mshafrir-stripe merged commit 718c2de into main Oct 23, 2023
@sunday-bernard-notarianni

Hello @mshafrir-stripe

I am sorry to contact here, but it seems there is no way to create a github issue on that repo.

I get the following error with my S700 DevKit, on that line:

discoveryCallback onFailure
com.stripe.stripeterminal.external.models.TerminalException: RPC application error INVALID_REQUEST with message Invalid device_type: must be one of bbpos_wisepad3, stripe_m2, stripe_s700, bbpos_chipper2x, bbpos_wisepos_e, verifone_P400, simulated_wisepos_e, or mobile_phone_reader
    at com.stripe.stripeterminal.handoffclient.HandoffAidlRpcListener.onComplete(HandoffAidlRpcListener.kt:48)
    at com.stripe.core.aidlrpc.AidlRpcListener$Stub.onTransact(AidlRpcListener.java:74)
    at android.os.Binder.execTransactInternal(Binder.java:1021)
    at android.os.Binder.execTransact(Binder.java:994)

The error message seems to indicate that stripe_s700 are allowed for Handoff discovery.
Maybe terminals with DeviceType stripe_s700_devkit are not allowed?

If that is the case, could it be possible to enable stripe_s700_devkit for Handoff discovery?

Thank for your help,

Bernard.

@mshafrir-stripe
Copy link
Collaborator Author

Hello @mshafrir-stripe

I am sorry to contact here, but it seems there is no way to create a github issue on that repo.

I get the following error with my S700 DevKit, on that line:

discoveryCallback onFailure
com.stripe.stripeterminal.external.models.TerminalException: RPC application error INVALID_REQUEST with message Invalid device_type: must be one of bbpos_wisepad3, stripe_m2, stripe_s700, bbpos_chipper2x, bbpos_wisepos_e, verifone_P400, simulated_wisepos_e, or mobile_phone_reader
    at com.stripe.stripeterminal.handoffclient.HandoffAidlRpcListener.onComplete(HandoffAidlRpcListener.kt:48)
    at com.stripe.core.aidlrpc.AidlRpcListener$Stub.onTransact(AidlRpcListener.java:74)
    at android.os.Binder.execTransactInternal(Binder.java:1021)
    at android.os.Binder.execTransact(Binder.java:994)

The error message seems to indicate that stripe_s700 are allowed for Handoff discovery. Maybe terminals with DeviceType stripe_s700_devkit are not allowed?

If that is the case, could it be possible to enable stripe_s700_devkit for Handoff discovery?

Thank for your help,

Bernard.

Please work your sales representative to enable Apps on Devices for your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants