This repository has been archived by the owner on May 6, 2020. It is now read-only.
[WIP] Support Bazel 0.28.1 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-stripe
force-pushed
the
andrew-bazel-28
branch
from
87f5b9c to
dfb2af5
Compare
johnynek
reviewed
Aug 5, 2019
| @@ -8,7 +8,15 @@ object BazelAst { | |||
|
|
|||
| final case class PyCall( | |||
| funName: String, | |||
| args: List[(String, PyExpr)] | |||
| args: List[PyExpr] = List(), | |||
There was a problem hiding this comment.
nit: Nil is slightly more efficient List() is a var-args so it allocates a zero length array for these.
| @@ -115,7 +132,39 @@ object BazelAst { | |||
| PyStr("scala_maven_import_external") | |||
| ) | |||
| ) | |||
| ) | |||
| ) ++ protobufVersion.map { case(version, sha256) => | |||
There was a problem hiding this comment.
case (version, sha256) => here would be standard style.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Bazel 0.28.1. We've instead decided to abandon using sbt-bazel in Rainier but I thought I should open the PR as a WIP in case someone wants to pick it up in the future. Feel free to close if preferred.