This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
Use partial order to support different split behaviors #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimal commit necessary to switch from using scala.math.Ordering to spire.algebra.PartialOrder in Predicate. This leaves other uses of scala.math.Ordering alone -- in fact we may want to switch those for spire.algebra.Order as well.
This commit completes the previous work adding PartialOrder. It also removes a bunch of unnecessary ordering constraints we had added (and instances we were capturing). It should not change how Brushfire actually works (yet).
erik-stripe
changed the title
|
Tests are good, but I don't think we need to flesh out the is-present stuff in this PR. Just moving |
|
OK, that makes sense. I'll do that next. |
This is an improvement since we have a principled way to handle the "error case" now.
|
Alright, |
|
This looks good to me. I do think if we are going to use spire more (and we should) we will get mileage out of the algebra work to make algebird, scalding and spire work better together. That or give up and make a |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves brushfire-core over to use
spire.algebra.PartialOrderandspire.algebra.Orderwhere applicable. At this point we don't actually use any partial orderings, but the support is there.Before we merge this I'd like to add some tests to prove this is working, and maybe flesh out support for the is present use-case a bit. What do you all think we need?
Review by @tixxit and @avibryant.