adjust supercronic download to allow multiarch builds #1053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download of
supercronic
in the Dockerfile hardcodesamd64
as the architecture, but we can make it flexible to allow for multiarch builds.For this purpose I added all three of the SHA1SUMs and just select the "correct" one to use based on the
ARCH
build argument (which has a default ofamd64
).This built successfully for me with the command:
(as well as
arm
andamd64
)I changed the shell that executes the Dockerfile to bash to take advantage of the
${!ENV_VAR_CONTAINING_OTHER_ENV_VAR_NAME}
construction - theSUPERCRONIC_SHA1SUM
arg contains one ofSUPERCRONIC_{amd64,arm,arm64}_SHA1SUM
, and we need to evaluate this value as an env var. The easiest way to do this with/bin/sh
seems to beeval echo \$$SUPERCRONIC_SHA1SUM
, but that's a bit unsafe since we're usingeval
so I selected to switch to bash instead.