Make maven sonatype plugin work also with Java 17, and publish for 17 only #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
scholzj
reviewed
Jun 27, 2023
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Done. Publishing artefacts will be done only in the scope of the Java 17 build pipeline. |
see-quick
changed the title
Frawless
approved these changes
Jun 28, 2023
scholzj
approved these changes
Jun 28, 2023
see-quick
added a commit
that referenced
this pull request
Jun 28, 2023
… only (#58) * Make maven sonatype plugin work also with Java 17 Signed-off-by: see-quick <maros.orsak159@gmail.com> * remove flakiness of test cases Signed-off-by: see-quick <maros.orsak159@gmail.com> * add conditional to push only in Java 17 Signed-off-by: see-quick <maros.orsak159@gmail.com> --------- Signed-off-by: see-quick <maros.orsak159@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older sonatype maven plugin (
1.6.3) is failing when pushing artefacts using Java 17. This update should solve such a problem with the latest version1.6.13.Basically a mirror of the strimzi/strimzi-kafka-operator#7946.
Plus I have added for flaky test cases (that it well try at least 3 times if they end up failing)
Plus, publishing artefacts will done only in scope of Java 17 build