Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check node and broker id equality in KRaft mode on start up and not in broker.id setter #125

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Check node and broker id equality in KRaft mode on start up and not in broker.id setter #125

merged 1 commit into from
Dec 20, 2024

Conversation

fedinskiy
Copy link
Contributor

Fixes #124

@fedinskiy fedinskiy force-pushed the fix/broker-id-setter branch from 85da96f to e3da8ea Compare December 20, 2024 13:33
@see-quick
Copy link
Member

Also, there are a few checkstyle errors i.e.,

[ERROR] /home/vsts/work/1/s/src/test/java/io/strimzi/test/container/StrimziKafkaKraftContainerIT.java:139:35: Empty statement. [EmptyStatement]
[ERROR] /home/vsts/work/1/s/src/test/java/io/strimzi/test/container/StrimziKafkaKraftContainerIT.java:141: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]

before you push always try to execute mvn clean install -DskipTests.

@see-quick see-quick added this to the 0.110.0 milestone Dec 20, 2024
@see-quick see-quick added the bug Something isn't working label Dec 20, 2024
@fedinskiy fedinskiy force-pushed the fix/broker-id-setter branch from e3da8ea to f629f03 Compare December 20, 2024 14:40
@fedinskiy fedinskiy requested a review from see-quick December 20, 2024 14:45
@see-quick
Copy link
Member

Also as you removed this one test case the mutation testing is failing because the average now of what is covered is less than it was before.

Line coverage of 71(326/459) is below threshold of 72

So please update it also in the pom.xml. Specifically here [1].

[1] - https://github.com/strimzi/test-container/blob/main/pom.xml#L458

@fedinskiy
Check node and broker id equality in KRaft mode on start up and not i…
d29325a 
…n broker.id setter

Fixes strimzi#124

Signed-off-by: Fedor Dudinsky <fdudinsk@redhat.com>
@fedinskiy fedinskiy force-pushed the fix/broker-id-setter branch from f629f03 to d29325a Compare December 20, 2024 15:15
see-quick
see-quick approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@see-quick see-quick requested a review from a team December 20, 2024 17:38
@see-quick see-quick merged commit 0f2e3f3 into strimzi:main Dec 20, 2024
7 checks passed
@fedinskiy fedinskiy deleted the fix/broker-id-setter branch December 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@see-quick see-quick see-quick approved these changes

Assignees

@fedinskiy fedinskiy

Labels
bug Something isn't working
Projects
None yet
Milestone
0.110.0
Development

Successfully merging this pull request may close these issues.

Code checks old brokerId when changin it in KRaft mode
3 participants
@fedinskiy @see-quick @scholzj