Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Surefire plugin #110

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Add Surefire plugin #110

merged 4 commits into from
Nov 13, 2024

Conversation

see-quick
Copy link
Member

This PR adds a surefire plugin to run UTs within the test container.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added this to the 0.109.0 milestone Nov 11, 2024
@see-quick see-quick mentioned this pull request Nov 11, 2024
@see-quick see-quick linked an issue Nov 11, 2024 that may be closed by this pull request
@see-quick see-quick self-assigned this Nov 11, 2024
@see-quick see-quick marked this pull request as ready for review November 11, 2024 13:52
@see-quick see-quick requested a review from a team November 11, 2024 13:52
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in all other projects we run the unit and integration tests with one step. Not sure if there is any reason to do it separately. If there is some reason for it and you want to keep it separate, its fine with me.

@see-quick
Copy link
Member Author

So, in all other projects we run the unit and integration tests with one step. Not sure if there is any reason to do it separately. If there is some reason for it and you want to keep it separate, its fine with me.

Hmmm, I wanted to do it simultaneously but now that I have mutation testing included I want to first check:

  1. Unit tests (if that works move to the next point)
  2. Mutation tests where I check coverage (i.e., mutation and line coverage) from Unit tests (if someone didn't cover a feature with Unit tests mutation/line coverage would fail otherwise one can provide to the next point)
  3. Run integration tests

@scholzj
Copy link
Member

scholzj commented Nov 12, 2024

Ok. As I said, if it has some reason, it is fine with with me.

pom.xml Outdated Show resolved Hide resolved
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick merged commit 22c08d2 into main Nov 13, 2024
7 checks passed
@see-quick see-quick deleted the run-also-uts branch November 14, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test execution
4 participants