Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kafka versions to mirror Strimzi kafka operator repository #34

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Dec 16, 2024

This PR updates our Kafka versions to mirror Strimzi Kafka Operator repository-supported versions. For the past two years, we haven't seen any benefit in supporting multiple Kafka versions, as most users use the latest version. For those reasons, we decided to support only SKO versions (typically 2-3 versions).

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added the enhancement New feature or request label Dec 16, 2024
@see-quick see-quick requested a review from a team December 16, 2024 14:59
@see-quick see-quick self-assigned this Dec 16, 2024
@see-quick see-quick added this to the 0.110.0 milestone Dec 16, 2024
@scholzj
Copy link
Member

scholzj commented Dec 16, 2024

Do we really need Kafka 3.7.2? We will never use it anywhere else as Strimzi.

@see-quick
Copy link
Member Author

Do we really need Kafka 3.7.2? We will never use it anywhere else as Strimzi.

Well, I am just updating x.y.max(z) as having a convention in it. I mean I can remove such a version but then we could have another discussion about version less than 3.7.2 (i.e.,

2.8.2
3.0.2
3.1.2
3.2.3
3.3.2
3.4.1
3.5.2
3.6.2

If we think it's useless to keep those versions then I can remove it.

@scholzj
Copy link
Member

scholzj commented Dec 16, 2024

Is anyone using it? I don't think any Strimzi project uses anything else than the latest version.

@im-konge
Copy link
Member

I would follow the support matrix of Strimzi, which also supports just two latest minor versions. I follow this pattern in test-clients as well - that's because we are running tests with all of the supported versions of Kafka by Strimzi.

@see-quick
Copy link
Member Author

Do we really need Kafka 3.7.2? We will never use it anywhere else as Strimzi.

Well, I am just updating x.y.max(z) as having a convention in it. I mean I can remove such a version but then we could have another discussion about version less than 3.7.2 (i.e.,

2.8.2
3.0.2
3.1.2
3.2.3
3.3.2
3.4.1
3.5.2
3.6.2

If we think it's useless to keep those versions then I can remove it.

Is anyone using it? I don't think any Strimzi project uses anything else than the latest version.

I thought Quarkus was using some older versions, but looking at the codebase, they are using just the latest version or the option to inject image via a constructor parameter (which would use different versions).

@see-quick
Copy link
Member Author

Do we really need Kafka 3.7.2? We will never use it anywhere else as Strimzi.

Well, I am just updating x.y.max(z) as having a convention in it. I mean I can remove such a version but then we could have another discussion about version less than 3.7.2 (i.e.,

2.8.2
3.0.2
3.1.2
3.2.3
3.3.2
3.4.1
3.5.2
3.6.2

If we think it's useless to keep those versions then I can remove it.

Is anyone using it? I don't think any Strimzi project uses anything else than the latest version.

I thought Quarkus was using some older versions, but looking at the codebase, they are using just the latest version or the option to inject image via a constructor parameter (which would use different versions).

So, based on my findings are we okay with shrinking those versions to mirror the support matrix of Strimzi? @scholzj @im-konge @strimzi/maintainers ?

@Frawless
Copy link
Member

Frawless commented Jan 7, 2025

Do we really need Kafka 3.7.2? We will never use it anywhere else as Strimzi.

Well, I am just updating x.y.max(z) as having a convention in it. I mean I can remove such a version but then we could have another discussion about version less than 3.7.2 (i.e.,

2.8.2
3.0.2
3.1.2
3.2.3
3.3.2
3.4.1
3.5.2
3.6.2

If we think it's useless to keep those versions then I can remove it.

Is anyone using it? I don't think any Strimzi project uses anything else than the latest version.

I thought Quarkus was using some older versions, but looking at the codebase, they are using just the latest version or the option to inject image via a constructor parameter (which would use different versions).

So, based on my findings are we okay with shrinking those versions to mirror the support matrix of Strimzi? @scholzj @im-konge @strimzi/maintainers ?

+1

@scholzj
Copy link
Member

scholzj commented Jan 7, 2025

+1 from me as well

1 similar comment
@im-konge
Copy link
Member

im-konge commented Jan 7, 2025

+1 from me as well

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick changed the title Update Kafka 3.7.x Update Kafka versions to mirror Strimzi kafka operator repository Jan 7, 2025
@see-quick
Copy link
Member Author

Thanks for the input I have updated the PR with description etc.

@see-quick see-quick merged commit d001f65 into main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants