Remove the Log Message and Inter Broker Protocol annotations #11177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Feb 24, 2025
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaConfiguration.java
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
force-pushed
the
remove-message-and-inter-broker-protocol-annotations
branch
from
1a1ea02 to
2e83398
Compare
ppatierno
approved these changes
Feb 24, 2025
scholzj
deleted the
remove-message-and-inter-broker-protocol-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR removes the
log.message.format.versionandinter.broker.protocol.versiontracking annotations we used to have on the Kafka Pods and which are not needed anymore / used for anything.It also removes the
MIN_INSYNC_REPLICASconstant from theKafkaConfigurationclass which was used only by theKafkaSpecCheckerand can be easily replaced by the field from theTopicConfigKafka class anyway.Checklist