Improve release_files_check script #10856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <maros.orsak159@gmail.com>
scholzj
reviewed
Nov 20, 2024
| echo "ERROR: Checksums of $DIRECTORY do not match." | ||
| echo " Expected: ${EXPECTED_CHECKSUM}" | ||
| echo " Actual: ${CHECKSUM}" | ||
| echo "If your changes to $DIRECTORY are related to a new release, please update the checksums. Otherwise, please change only the files in the $PACKAGING_DIR directory. " |
There was a problem hiding this comment.
Suggested change
| echo "If your changes to $DIRECTORY are related to a new release, please update the checksums. Otherwise, please change only the files in the $PACKAGING_DIR directory. " | |
| echo "If your changes to $DIRECTORY are related to a new release, please update the checksums. Otherwise, please change only the files in the $PACKAGING_DIR directory." |
There was a problem hiding this comment.
Seems to work
./.azure/scripts/release_files_check.sh
ERROR: Checksums of ./install do not match.
Expected: 4e3bc4774c0d1803e895d42e22d792364b2f14c5 -
Actual: 61a5673f862fb693f43dbda4303879929e6b2b04 -
If your changes to ./install are related to a new release, please update the checksums. Otherwise, please change only the files in the ./packaging/install directory.
ERROR: Checksums of ./examples do not match.
Expected: 2bbd52b17af9b7ef63731b4a0a81165b182d77e6 -
Actual: 9ec480c825d9d58a92293a9995aff1986066071b -
If your changes to ./examples are related to a new release, please update the checksums. Otherwise, please change only the files in the ./packaging/examples directory.
ERROR: Checksums of ./helm-charts do not match.
Expected: 50e2ee0738ebfd558fa2e35c189b3abb5e3a5663 -
Actual: efcada371739e2823cacd18f545216f11673b589 -
If your changes to ./helm-charts are related to a new release, please update the checksums. Otherwise, please change only the files in the ./packaging/helm-charts directory.
make: *** [Makefile:138: release_files_check] Error 3
##[error]Bash exited with code '2'.
Finishing: Check released files
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Maros Orsak <maros.orsak159@gmail.com>
scholzj
approved these changes
Nov 21, 2024
im-konge
approved these changes
Nov 21, 2024
OwenCorrigan76
pushed a commit
to OwenCorrigan76/strimzi-kafka-operator
that referenced
this pull request
Dec 6, 2024
Signed-off-by: see-quick <maros.orsak159@gmail.com> Signed-off-by: Maros Orsak <maros.orsak159@gmail.com> Co-authored-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR update our release_files_check.sh script, which is used to check if someone changes examples, installs or helm charts directories. As we improve the procedure in the KAO repository I also wanted to update here in the operator's repo. For context, here is KAO PR with such changes [1].
[1] - strimzi/kafka-access-operator#66
Checklist