-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed autoRebalance
status not reset when auto-rebalancing or Cruise Control is not enabled
#10652
Merged
ppatierno
merged 4 commits into
strimzi:main
from
ppatierno:fix-autorebalance-status-update
Oct 1, 2024
Merged
Fixed autoRebalance
status not reset when auto-rebalancing or Cruise Control is not enabled
#10652
ppatierno
merged 4 commits into
strimzi:main
from
ppatierno:fix-autorebalance-status-update
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control is not enabled Signed-off-by: Paolo Patierno <ppatierno@live.com>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
Sep 29, 2024
...rator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaAssemblyOperator.java
Outdated
Show resolved
Hide resolved
...rator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaAssemblyOperator.java
Outdated
Show resolved
Hide resolved
time Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
8 tasks
scholzj
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. LGTM otherwise.
...rator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaAssemblyOperator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <ppatierno@live.com>
scholzj
approved these changes
Oct 1, 2024
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
When the cluster starts without Cruise Control enabled or without auto-rebalance configured, the corresponding status is set anyway (which on cluster creation is anyway wrong, because it's not a scaling up operation).
When Cruise Control or auto-rebalance configuration is removed, the status is not reset as well.
For example, you create a Kafka cluster with:
on creation, the status contains the following:
It hasn't to be there, because
cruiseControl.autoRebalance
is not enabled at all and it's even cluster creation not scaling up.No auto-rebalance runs but the status is anyway wrong.
Another example, you create a Kafka cluster with
cruiseControl.autoRebalance
configured so the status is:and then you remove the
autoRebalance
part of it or even the entirecruiseControl
section.The
status.autoRebalance
should disappear because keeping the info about the "Idle" state doesn't make any sense anymore (auto-rebalance is not configured).This PR fixes the above issue(s), also improving the way the
KafkaAssemblyOperator
can make the decision about running or not the auto-rebalacing reconciliation at all. This way some state initialization is also pulled out from the reconcile of theKafkaAutoRebalancingReconciler
.Checklist