Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CharacterComponent can stand on trigger boxes #2562

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Dec 16, 2024

PR Details

Characters could continuously jump inside and stand on top of a NoContactResponse Collidable - NoContactResponse still notifies IContactEventHandler of course, which CharacterController depends on to figure out whether it should be falling or if it can jump.

Related Issue

None reported.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator Author

Eideren commented Dec 16, 2024

This is a really simple change and no one's got time to test/review, it works as expected so I'll just merge it in now.

@Eideren Eideren merged commit d13bb04 into stride3d:master Dec 16, 2024
2 checks passed
@Eideren Eideren deleted the character_ctct_resp branch December 16, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant