Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get LocalAppData path from Environment.SpecialFolder enum #2511

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Nov 8, 2024

PR Details

Getting LocalAppData path shouldn't be hardcoded if we want more universal code for all platforms. It should be received from Environment.GetFolderPath with Environment.SpecialFolder enum which contains common paths for OS folders.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk changed the title feat: Get LocalAppData path from Environment.SpecialFolder object feat: Get LocalAppData path from Environment.SpecialFolder enum Nov 8, 2024
@Eideren Eideren merged commit 233e41e into stride3d:master Dec 6, 2024
2 checks passed
@Jklawreszuk Jklawreszuk deleted the nuget-asm branch December 6, 2024 17:22
@Eideren
Copy link
Collaborator

Eideren commented Dec 6, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants