Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed AssImp unsupported pivot bone error to warning #2467

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented Sep 24, 2024

PR Details

Some projects fail to build due to a possible regression in the AssImp importer from FBX. The failure is due to FBX files being given virtual nodes that describe translation, rotation and scale in the form of $AssimpFbx$ nodes. This changes the error to be a warning as it seems to be importing correctly and animating correctly.

These were 3 previously problematic models that seem to be working fine:
image

Related Issue

#2459 - technically a fix for the reported issue but not for the actual cause.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit e4d7e80 into stride3d:master Sep 25, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 25, 2024

Thanks !

@Eideren Eideren changed the title changed AssImp error to warning fix: Changed AssImp error to warning Sep 25, 2024
@Eideren Eideren changed the title fix: Changed AssImp error to warning fix: changed AssImp unsupported pivot bone error to warning Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants