Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Math] - Exponential damping #2461

Merged
merged 3 commits into from
Sep 22, 2024
Merged

feat: [Math] - Exponential damping #2461

merged 3 commits into from
Sep 22, 2024

Conversation

NicusorN5
Copy link
Contributor

PR Details

Add ExpDecay to both MathUtil and SDSL as an alternative to damping using linear interpolation.

Related Issue

Closes #2301 .

Types of changes

  • [N/A] Docs change / refactoring / dependency upgrade
  • [N/A] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [N/A] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [N/A] My change requires a change to the documentation.
  • [N/A] I have added tests to cover my changes.
  • [N/A] All new and existing tests passed.
  • I have built and run the editor to try this change out.

@NicusorN5 NicusorN5 changed the title Exponential damping feat: [Math] Exponential damping Sep 22, 2024
@NicusorN5 NicusorN5 changed the title feat: [Math] Exponential damping feat: [Math] - Exponential damping Sep 22, 2024
Eideren
Eideren reviewed Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@Eideren Eideren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this one !

sources/engine/Stride.Rendering/Rendering/Utils/Math.sdsl Outdated Show resolved Hide resolved
@Eideren Eideren added the area-Math Issues related to the Stride.Core.Mathematics namespace label Sep 22, 2024
@NicusorN5 NicusorN5 requested a review from Eideren September 22, 2024 11:01
@Eideren Eideren merged commit 2829889 into stride3d:master Sep 22, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 22, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eideren Eideren Awaiting requested review from Eideren

Assignees
No one assigned
Labels
area-Math Issues related to the Stride.Core.Mathematics namespace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ExpDecay function for framerate independent damping
2 participants
@NicusorN5 @Eideren