Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring NuGet packages in the editor #2432

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Basewq
Copy link
Contributor

@Basewq Basewq commented Sep 5, 2024

Fix restoring NuGet packages in the editor

PR Details

Finer details regarding the TFM are explained in the comments of #2426
When using shorthand TFM (eg. net8.0-windows), MSBuild sets the default platform version in TargetPlatformVersion when not explicitly set and the expanded canonical version (eg. net8.0-windows7.0) is passed to packaging to NuGet.
NuGet resolver requires the canonical form of the target framework moniker (TFM) when the OS/platform has been specified
ie. [framework]-[platform][platform_version]
This fix ensures the platform version is passed when applicable.

Related Issue

Fixes #2426
Caused by #2205

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

…(TFM) when passed to NuGet resolver to properly load NuGet libraries
@Eideren Eideren merged commit 4ebbf54 into stride3d:master Sep 6, 2024
6 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 6, 2024

Thanks !

@Basewq Basewq deleted the nuget_resolver_fix branch September 8, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stride.GameStudio Startup - Error Restoring NuGet packages!
3 participants