feat: Custom Depth Test Function for Materials #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eideren
changed the title
Doprez
reviewed
Aug 18, 2024
There was a problem hiding this comment.
This is an exciting addition, this could be used to improve https://github.com/profan/XenkoByteSized?tab=readme-ov-file#xenkobytesizedproceduralmeshsubdividedplanemesh with some visual feedback.
I don't see any concerns other than a few small typos.
sources/engine/Stride.Rendering/Rendering/Materials/MaterialAttributes.cs
Outdated
Show resolved
Hide resolved
sources/engine/Stride.Rendering/Rendering/Materials/MaterialAttributes.cs
Outdated
Show resolved
Hide resolved
Doprez
approved these changes
Aug 19, 2024
NicusorN5
approved these changes
Aug 19, 2024
Eideren
added a commit
to Eideren/xenko
that referenced
this pull request
Oct 2, 2024
* [Graphics] Custom Depth Test Function for Materials * Fix typo (cherry picked from commit 9bde7c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Provides the ability for users to set custom depth testing functions per material for special effects
Here, a sphere clipped into another sphere by using the
Greaterdepth functionThis is often used for bullet impacts, selections in RTS, previews in level editors ...
Related Issue
None afaict.
Types of changes
Checklist