Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depth calculation for MipMap views of 3D textures #2375

Merged

Conversation

tebjan
Copy link
Member

@tebjan tebjan commented Jul 7, 2024

PR Details

When creating a single MipMap slice view of a Texture3D the Depth is calculated correctly.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit 3797e5d into stride3d:master Jul 8, 2024
6 checks passed
@Eideren Eideren changed the title Fixes depth calculation for MipMap views of 3D textures fix: depth calculation for MipMap views of 3D textures Jul 8, 2024
@Eideren
Copy link
Collaborator

Eideren commented Jul 8, 2024

Thanks !

@tebjan tebjan deleted the dev/tebjan/fix-mip-subresource-texture3d branch July 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants