fix: getting app exe path when using PublishSingleFile #2352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Use
PlatformFolders.ApplicationExecutablePath
instead ofAssembly.GetEntryAssembly().Location
https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/overview?tabs=cli#api-incompatibility
Under 'API incompatibility'
Assembly.Location
is not available with single file deployment.https://learn.microsoft.com/en-us/dotnet/api/system.environment.processpath?view=net-8.0
Environment.ProcessPath
can be used as a fallback, but do note that even that can return null.Related Issue
Fixes #2304 where Icon is set via
GameContext.ProductLocation
Also fixes the super secret LeftCtrl + C+ F1 screenshot command in PublishSingleFile.
Types of changes
Checklist