Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update SharpFont library for additional fixes #2318

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Basewq
Copy link
Contributor

@Basewq Basewq commented Jun 10, 2024

PR Details

Successor to #2281
Must wait until pull at stride3d/SharpFont#1 is merged and its nuget package has been updated to 1.0.1.

My understanding of Stride's build of SharpFont:

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator

Eideren commented Jun 10, 2024

You're a god send, thanks a ton for taking over this one @Basewq and for looking into this further than I had :)

@Basewq
Copy link
Contributor Author

Basewq commented Jun 10, 2024

All good, I should be thanking you! Spent hours trying to find solve a font display bug, then stumbled on your pull which helped finally figure out the issue. Really good timing, lol.

Also fixed the issue on the other repo, should be going to the right branch now.

@Eideren
Copy link
Collaborator

Eideren commented Jun 10, 2024

I'll look into publishing the package once teamcity is up

@Basewq Basewq marked this pull request as ready for review June 30, 2024 23:37
@Basewq
Copy link
Contributor Author

Basewq commented Jun 30, 2024

Ready to merge. While there are some fixes within SharpFont, none appears to have impacted Stride at this time, so consider this more of a future proofing update.

Realistically, if there are font bugs that need fixing, consider updating the stride version of freetype repo: https://github.com/stride3d/freetype

@Eideren Eideren merged commit 90ebbe5 into stride3d:master Jul 1, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jul 1, 2024

Thanks !

@Eideren Eideren changed the title [Font] Update SharpFont library for additional fixes fix: Update SharpFont library for additional fixes Jul 1, 2024
@Basewq Basewq deleted the sharpfont_update branch July 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants