Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ModelComponent bounds gizmos #2294

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

kristian15959
Copy link
Contributor

PR Details

This PR adds bounding box gizmo for ModelComponent in editor, can be disabled like any other gizmo in scene view.

Motivation and Context

Detecting problems with mesh/models rendering can become a problematic when you do not know if bounds have correct position and extents.
Updating to 64bit coords showed problematic when converting Meshes to use Double BoundingBoxes and could not see if the correct data was there.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

image

@kristian15959
Copy link
Contributor Author

@dotnet-policy-service agree

@Eideren Eideren merged commit 4e6a456 into stride3d:master May 29, 2024
13 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 29, 2024

Looks great, thanks !

@Eideren Eideren changed the title Added: ModelComponent bounds gizmos feat: ModelComponent bounds gizmos May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants