Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add linux VHACD shared library #2293

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

This PR adds the generated binary of VHACD shared library for Linux using my BulletSharp fork

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator

Eideren commented May 28, 2024

Can you make a PR on our bulletsharp repo to merge your changes in ?

@Eideren Eideren merged commit 5d5f91d into stride3d:master May 28, 2024
13 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 28, 2024

Thanks !

@Jklawreszuk Jklawreszuk deleted the vhacd-lin branch May 28, 2024 10:29
@Jklawreszuk
Copy link
Collaborator Author

Can you make a PR on our bulletsharp repo to merge your changes in ?

@Eideren Sure 😀, here's the PR stride3d/BulletSharpPInvoke#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants