fix: Use CompilerApp crossplatform binary instead of exe #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great, thanks ! |
8 tasks
VaclavElias
reviewed
May 29, 2024
| @@ -125,8 +125,8 @@ | |||
| <Target Name="_StridePrepareAssetCompiler"> | |||
| <PropertyGroup> | |||
| <!-- First try NuGet layout, then git checkout --> | |||
| <StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\lib\net8.0\')">$(MSBuildThisFileDirectory)..\lib\net8.0\Stride.Core.Assets.CompilerApp.exe</StrideCompileAssetCommand> | |||
| <StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\Stride.Core.Assets.CompilerApp.csproj')">$(MSBuildThisFileDirectory)..\bin\$(Configuration)\net8.0\Stride.Core.Assets.CompilerApp.exe</StrideCompileAssetCommand> | |||
| <StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\lib\net8.0\')">$(MSBuildThisFileDirectory)..\lib\net8.0\Stride.Core.Assets.CompilerApp.dll</StrideCompileAssetCommand> | |||
There was a problem hiding this comment.
I see, that we are referencing here net8.0 (also in the old version), can we make it somehow dynamic, so when we upgrade to a new version of .NET that we don't have to come back here to update?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Since CompilerApp does not contain any Windows-dependent code (at least directly), I suggest using the
dotnet Stride.Core.Assets.CompilerApp.dllinstead of running Stride.Core.Assets.CompilerApp.dllThis ensures working on any platform:
https://learn.microsoft.com/en-us/dotnet/core/deploying/#publish-framework-dependent
✔️ Tested on Linux it works perfectly. Need to ensure though, there is not regression on Windows
Types of changes
Checklist