fix: Get correct PackageCompiler.SdkDirectory for all platforms #2271
Conversation
Jklawreszuk
force-pushed
the
StrideSdkDirFix
branch
from
b983de4 to
47b4afb
Compare
| // from ../bin/Debug/net{version} -> ../bin | ||
| SdkDirectory = Directory.GetParent(codeBase)?.Parent?.Parent?.FullName ?? ""; |
There was a problem hiding this comment.
Directory goes through and reads from the filesystem afair while Path just works on the string representation of the path.
You can chain Path.GetDirectoryName calls if you want to do something similar, see examples in
https://learn.microsoft.com/en-us/dotnet/api/system.io.path.getdirectoryname?view=net-8.0#system-io-path-getdirectoryname(system-string)
There was a problem hiding this comment.
@Eideren Good point. I did a simple benchmark and my fix was about 2 times slower. I started all over and I noticed UriBuilder does nothing so I removed it so it wouldn't throw an exception anymore
There was a problem hiding this comment.
@Eideren I get it now why UriBuilder was in the first place! Thats because .NET Framework Assembly.CodeBase (5059972) was returning URI path : https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assembly.codebase?view=net-8.0 which is useless now.
Jklawreszuk
force-pushed
the
StrideSdkDirFix
branch
from
47b4afb to
f6ec570
Compare
|
Thanks ! |
PR Details
Description
PR simplifies getting correct SdkDirectory path. The previous way of moving folders two up, used
UriBuilder, but it threw an exception on Unix systemsMotivation and Context
This PR is a part of making AssetCompiler crossplatform.
Types of changes
Checklist