Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VS component check should only be performed for Win OS #2270

Merged
merged 1 commit into from
May 25, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

Description

IsVSComponentAvailableAnyVersion method currently may throw exception if executed on platform other than Windows - this prevents AssetCompilerApp from running e.g. on Linux.

Motivation and Context

This PR is a part of making AssetCompiler crossplatform.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk changed the title Fix: VS component check should only be performed for Win OS fix: VS component check should only be performed for Win OS May 24, 2024
@Jklawreszuk Jklawreszuk force-pushed the vs-component-checking branch from 619cbc0 to 1e32329 Compare May 24, 2024 21:38
@Eideren Eideren merged commit f78587d into stride3d:master May 25, 2024
13 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 25, 2024

Thanks !

@Jklawreszuk Jklawreszuk deleted the vs-component-checking branch May 26, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants