Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenXR] Adds a minimal API to request and control Passthrough #2141

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

azeno
Copy link
Collaborator

@azeno azeno commented Feb 6, 2024

PR Details

Description

Follow up on #2119 and #2121. It adds the following new public APIs:

  • VRDeviceSystem.RequestPassthrough - needs to be set in order for the OpenXR extension to get considered.
  • VRRendererSettings.RequestPassthrough - can be set in GameStudio and get passed to the VR device system by the ForwardRenderer
  • VRDevice.SupportsPassthrough - does the device support it?
  • VRDevice.StartPassthrough - needs to be called by user code to turn the feature on

The PR is a little bit different to the original one not exposing internal classes to the user. Not entirly sure here what is the best approach. It's only supported by OpenXR and there also by some devices, but having to cast on these types manually in Stride game code seems awkward as well.

Related Issue

#2119 and #2121

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@azeno azeno changed the title [OpenVR] Adds a minimal API to request and control Passthrough (OpenXR) [OpenXR] Adds a minimal API to request and control Passthrough Feb 6, 2024
@manio143
Copy link
Member

manio143 commented Feb 7, 2024

Overall looks good. The bool property indicating support is great as it clearly indicates to the user if they can enable this passthrough mode on the given device/VR system.

@azeno azeno force-pushed the openxr-passthrough branch from ff27bf7 to ea94936 Compare February 7, 2024 11:53
@joreg
Copy link
Contributor

joreg commented Feb 26, 2024

@manio143 do you think there is now anything left holding this back from being merged?

@manio143
Copy link
Member

I'll run the build and if it passes I'll merge it. Thanks for reminder

@manio143 manio143 merged commit 733d2d2 into stride3d:master Feb 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants