Make Stride.Core.Presentation cross-platform #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI-agnostic and cross-platform
Rename previous IDialogService to IDialogService2
Jklawreszuk
reviewed
Dec 16, 2023
...Presentation/AssetEditors/EntityHierarchyEditor/ViewModels/EntityHierarchyEditorViewModel.cs
Outdated
Show resolved
Hide resolved
Kryptos-FR
force-pushed
the
feature/xplat/core-presentation
branch
2 times, most recently
from
15604d2 to
6b7c7ef
Compare
And move it to IDialogService
Kryptos-FR
force-pushed
the
feature/xplat/core-presentation
branch
from
6b7c7ef to
827ce0f
Compare
Eideren
approved these changes
Jan 7, 2024
sources/presentation/Stride.Core.Presentation/Services/IDialogService.cs
Show resolved
Hide resolved
sources/presentation/Stride.Core.Presentation/Stride.Core.Presentation.csproj
Show resolved
Hide resolved
Jklawreszuk
approved these changes
Jan 8, 2024
|
Quite impresive work, LGTM, but I would like to add few comments 😅 |
Jklawreszuk
reviewed
Jan 10, 2024
sources/assets/Stride.Core.Assets.CompilerApp/build/Stride.Core.Assets.CompilerApp.targets
Show resolved
Hide resolved
Jklawreszuk
reviewed
Jan 10, 2024
sources/assets/Stride.Core.Assets.CompilerApp/Stride.Core.Assets.CompilerApp.csproj
Show resolved
Hide resolved
|
@Eideren @Jklawreszuk ok to merge? I added two commits to get IDialogService closer to describing the service in a xplat way. The signature of most methods follow closely Avalonia's implementation, which can explain why the current WPF's implementation is a bit clumsy. |
|
Thanks ! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Make
Stride.Core.Presentationcross-platform and UI-agnostic (albeit still dependent on the MVVM pattern), and move Windows/WPF-specific code toStride.Core.Presentation.Wpf.In addition, a few other libraries now target
net-8.0instead of.net-8.0-windows7.0.Bonus point: the code in
Stride.Core.Presentationis modernized with implicit usings and nullable reference support.Related Issue
Partially based on #2034, which will be rebased on top of this PR once merged.
Motivation and Context
Mostly code reuse.
Also, the launcher has much less dependencies on WPF than the other editor libraries. With that change, it should be possible to start porting it to Avalonia with minimal effort, and independently from the rewrite.
Types of changes
Checklist