[Build] Fix build following changes from #2045 #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
reviewed
Nov 21, 2023
| <AnalyzersNotToRemove Include="@(Analyzer)" Condition="$([System.String]::Copy(%(FullPath)).Contains('Stride'))" /> | ||
| <AnalyzersNotToRemove Include="@(Analyzer)" Condition="$(FullPath.Contains('Stride'))" /> |
There was a problem hiding this comment.
It looks like this line is the only thing that is needed to fix it. I'm not sure why it is triggering now, since that wasn't part of the central package management change.
There was a problem hiding this comment.
With that said, I guess we can merge the whole since it's better not to keep this VersionOverride exception.
To be tested with a TeamCity build.
There was a problem hiding this comment.
To be clear, that particular change was the first one I made to try and fix the build system, it wasn't enough for my case. Probably because I built it once before making any changes, leading to a stale target or something breaking further builds.
Kryptos-FR
approved these changes
Nov 21, 2023
|
Builds are okay, merging this. |
Kryptos-FR
added a commit
to Kryptos-FR/stride
that referenced
this pull request
Dec 30, 2023
This was preventing them from being included in all projects (see stride3d#2061).
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Build system was confused with the
VersionOverridewhen building from zero.Related Issue
Fixes #2059
Types of changes
Checklist
Pinging @Kryptos-FR to verify this, I know you left a comment on that particular change in #2045 but it builds fine on my end - let me know if the changes I introduced are problematic.