Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Move Directory.Packages.props #2055

Merged
merged 4 commits into from
Dec 30, 2023
Merged

[Build] Move Directory.Packages.props #2055

merged 4 commits into from
Dec 30, 2023

Conversation

Kryptos-FR
Copy link
Member

PR Details

Follows #2045 and #2052.

Description

Move the file under sources/ to avoid impact with deps/ and samples/.

@Kryptos-FR Kryptos-FR marked this pull request as draft November 20, 2023 17:05
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management branch from 617d137 to 2b8b33a Compare November 20, 2023 20:20
@tebjan
Copy link
Member

tebjan commented Nov 20, 2023

That makes sense, thanks!

@Eideren
Copy link
Collaborator

Eideren commented Nov 22, 2023 •
edited
Loading

There is a bunch of new warnings that showed up with your previous related PR, There are 2 package sources defined in your configuration. When using central package management, please map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source. The following sources are defined: nuget.org, Stride - would be nice to address those in this PR if you have time

@Kryptos-FR
Copy link
Member Author

Kryptos-FR commented Nov 22, 2023 •
edited
Loading

There is a bunch of new warnings that showed up with your previous related PR, There are 2 package sources defined in your configuration. When using central package management, please map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source. The following sources are defined: nuget.org, Stride - would be nice to address those in this PR if you have time

This has to be done by each developer. It has to do with your local Nuget.config. I want to avoid adding a custom Nuget.config on the repo as it might collide with developers' own. The repo itself only has one source: nuget. Only if you have installed Stride locally do you have additional ones (Stride, StrideDev).

edit actually StrideDev is linked to this repo. However, if we start to set the source for it, it might make some tests or run fail when it tries to get other stride packages that are not built yet. Let me think about i.

@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management branch from 2b8b33a to 9d0859c Compare December 8, 2023 09:10
@Kryptos-FR
Copy link
Member Author

@dotnet-policy-service agree

It's broken. I already signed on another PR.

@VaclavElias
Copy link
Contributor

You signature wasn't trusted 😂. Make sure you don't sign with your left hand, if you write with your right hand 🤣.

@Kryptos-FR
Copy link
Member Author

@Eideren I added a nuget.config. Looks like we just need the single nuget.org source here.

@Kryptos-FR Kryptos-FR marked this pull request as ready for review December 8, 2023 13:50
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management branch 2 times, most recently from 1952120 to 73789a3 Compare December 8, 2023 14:07
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management branch from 73789a3 to 78cf1ca Compare December 17, 2023 19:56
@Kryptos-FR Kryptos-FR mentioned this pull request Dec 28, 2023
Merged
8 tasks
@xen2 xen2 merged commit 1fe15d2 into stride3d:master Dec 30, 2023
2 checks passed
@Kryptos-FR Kryptos-FR deleted the feature/central-package-management branch December 30, 2023 16:54
This was referenced Dec 30, 2023
Closed
Merged
recore67 added a commit to recore67/stride that referenced this pull request Jan 1, 2024
@recore67
Squashed commit of the following:
4b0ec02 
commit 92274a2
Author: salman ameeri <29689492+recore67@users.noreply.github.com>
Date:   Sun Dec 31 02:20:28 2023 +0300

    openxr files removed

commit 4822e84
Author: salman ameeri <29689492+recore67@users.noreply.github.com>
Date:   Sun Dec 31 01:44:35 2023 +0300

    initial start of vr stripping

commit 16a5fb1
Author: salman ameeri <29689492+recore67@users.noreply.github.com>
Date:   Sat Dec 30 18:10:42 2023 +0300

    more platform stripping

commit 71e55c3
Author: salman ameeri <29689492+recore67@users.noreply.github.com>
Date:   Fri Dec 29 23:12:01 2023 +0300

    fbx import error

commit 1feb124
Author: Virgile Bello <virgile@stride3d.net>
Date:   Sun Dec 31 10:22:17 2023 +0900

    [NuGet] Ignore case when comparing assembly file names

commit ef52eba
Author: Virgile Bello <virgile@stride3d.net>
Date:   Sun Dec 31 10:09:15 2023 +0900

    [Build] Skip localization assembly build during dev build

commit 1fe15d2
Merge: c4965c3 78cf1ca
Author: xen2 <virgile@stride3d.net>
Date:   Sun Dec 31 00:04:23 2023 +0900

    Merge pull request stride3d#2055 from Kryptos-FR/feature/central-package-management

    [Build] Move Directory.Packages.props

commit 78cf1ca
Author: Nicolas Musset <musset.nicolas@gmail.com>
Date:   Fri Dec 8 14:55:10 2023 +0100

    Add nuget.config to Stride.sln

commit 6f2df39
Author: Nicolas Musset <musset.nicolas@gmail.com>
Date:   Fri Dec 8 14:49:51 2023 +0100

    [Build] Don't use central package management for Stride.Samples.Tests

    It is confused by nuget configurations.

commit c5bff0d
Author: Nicolas Musset <musset.nicolas@gmail.com>
Date:   Fri Dec 8 14:48:54 2023 +0100

    Add nuget.config

commit 1f0be73
Author: Nicolas Musset <musset.nicolas@gmail.com>
Date:   Mon Nov 20 17:55:21 2023 +0100

    [Build] Move Directory.Packages.props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen2 xen2 xen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kryptos-FR @tebjan @Eideren @VaclavElias @xen2