-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #2058: Improve developer installation, remove pip_install_strictdoc_deps.py #2060
base: main
Are you sure you want to change the base?
Resolves #2058: Improve developer installation, remove pip_install_strictdoc_deps.py #2060
Conversation
I am aware that I have broken |
206fe69
to
f381789
Compare
pip_install_strictdoc_deps.py requires a manual pip install of the toml module before it works with a fresh virtual environment. We can achieve a working installation much easier with a virtual environment (which is better practice anyway) and pip. This begs the question of whether this script is needed at all. Delete it, and make the corresponding updates to the Dev Guide and tox.ini.
|
f381789
to
4da3b72
Compare
I have re-evaluated this and learned more about using |
Hmm, I am noticing one more thing: I mistakenly forgot to update the EDIT: Just tried it. Although it does indeed update the
Is this desirable? |
Hey @nogjam , thanks for reviewing this setup step and contributing a possible improvement. Before implementing the current solution, I had definitely tried doing the setup your way, but I encountered a limitation of Could you confirm that this problem indeed exists and suggest a possible workaround? Thanks for looking into this. I am all in for simpler solutions. |
Hmm, I thought only
Could you please clarify and/or provide an example of this undesirable behavior? |
Here's some more information from https://setuptools.pypa.io/en/latest/userguide/development_mode.html:
Is the kind of problem you're thinking of something that |
pip_install_strictdoc_deps.py requires a manual pip install of the toml module before it works with a fresh virtual environment. We can achieve a working installation much easier with a virtual environment (which is better practice anyway) and pip. This begs the question of whether this script is needed at all. Delete it, and make the corresponding updates to the Dev Guide and tox.ini.