Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format code with goimports #785

Merged
merged 1 commit into from
Mar 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion http/test_round_tripper.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package http

import (
"github.com/stretchr/testify/mock"
"net/http"

"github.com/stretchr/testify/mock"
)

// TestRoundTripper DEPRECATED USE net/http/httptest
Expand Down
3 changes: 2 additions & 1 deletion package_test.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package testify

import (
"github.com/stretchr/testify/assert"
"testing"

"github.com/stretchr/testify/assert"
)

func TestImports(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion suite/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func Run(t *testing.T, suite TestingSuite) {
defer failOnPanic(t)

suiteSetupDone := false

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are not related to imports

methodFinder := reflect.TypeOf(suite)
tests := []testing.InternalTest{}
for index := 0; index < methodFinder.NumMethod(); index++ {
Expand Down
2 changes: 1 addition & 1 deletion suite/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ func TestRunSuite(t *testing.T) {
type SuiteSetupSkipTester struct {
Suite

setUp bool
setUp bool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are not related to imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goimports does both import ordering as well as calling gofmt.

Copy link

@bencampbell-wf bencampbell-wf Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This change would lead me to believe the go formatting check defined during CI is not being run.

FYI: @georgelesica-wf

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, weird...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, hopefully... #804

toreDown bool
}

Expand Down