web: add tab keyboard shortcuts #7322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
requested changes
Jan 27, 2025
Comment on lines
61
to
68
| { | ||
| is: (event: KeyboardEvent) => | ||
| IS_DESKTOP_APP && | ||
| (event.ctrlKey || event.metaKey) && | ||
| event.shiftKey && | ||
| event.key === "T", | ||
| action: () => useEditorStore.getState().undoCloseSession() | ||
| } |
There was a problem hiding this comment.
Is this shortcut really necessary?
There was a problem hiding this comment.
If we're adding all the other tab shortcuts, I think it is worth adding an undo close tab shortcut
01zulfi
force-pushed
the
feat/more-tab-shortcuts
branch
from
d54477d to
a82ce0e
Compare
* add desktop shortcuts: ctrl+w, ctrl+n, ctrl+t, ctrl+shift+t, ctrl+tab, ctrl+shift+tab * update task list toggle shortcut from ctrl+shift+t to ctrl+alt+shift+t Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
01zulfi
force-pushed
the
feat/more-tab-shortcuts
branch
from
a82ce0e to
848bc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6250
Related to #4828 #1014