Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix link to zulip logo #5848

Merged
merged 1 commit into from
Jul 2, 2024
Merged

docs: fix link to zulip logo #5848

merged 1 commit into from
Jul 2, 2024

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Jul 2, 2024

No description provided.

@Jason3S Jason3S marked this pull request as ready for review July 2, 2024 05:59
nschonni
nschonni reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 copies of the SVG, but only one appears used from the changed lines

@Jason3S
Copy link
Collaborator Author

Jason3S commented Jul 2, 2024

There are 2 copies of the SVG, but only one appears used from the changed lines

GitHub markdown will use the one in the root.
The Jekyll website picks it up under docs (or so I hope).

@Jason3S Jason3S merged commit aed239a into main Jul 2, 2024
13 checks passed
@Jason3S Jason3S deleted the dev-readme branch July 2, 2024 08:46
@Jason3S
Copy link
Collaborator Author

Jason3S commented Jul 2, 2024

There are 2 copies of the SVG, but only one appears used from the changed lines

Thank you for asking.

@Jason3S
Copy link
Collaborator Author

Jason3S commented Jul 2, 2024

It worked: https://cspell.org/#live-discussions

This was referenced Jul 24, 2024
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 7, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 19, 2024
Open
@jpjpjp
Copy link

jpjpjp commented Sep 23, 2024

@Jason3S @nschonni, I realize this is closed, but I've noticed that there hasn't been any conversation on your channel. Are you still planning to support this?

Currently, if you do want to compose a message on the channel, it asks you to sign in to Zulip. If you choose to create an account, you are redirected here: https://cspell.zulipchat.com/register/. This page indicates that an invitation from cspell is required to sign up. Is there a process for requesting an invite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jason3S @jpjpjp @nschonni