Cycleway overlay #4657

westnordost · 2022-11-29T22:58:58Z

refactored cycleway, street parking and sidewalk parsers to be be consistent and properly handle all edge cases when tagging only one side (fixes Crash when adding a parking lane #4634). A side-effect of this is that the app will always merge same *:left and *:right values to *:both as was requested several times somewhere in this issue tracker and where I was like 🤷 before.
refactored cycleway quest to share as much code with the overlay as possible
fixed a bug in cycleway parsing: If in flow direction of a oneway there was a dual track or dual lane and in contra-flow direction there was nothing, the parser would wrongly interpret the contra-flow side as being "none, no oneway", i.e. as if bicycles could go in contraflow on the street itself
made cycleway parser more strict: The parser does not accept values like on_street, none etc. anymore / classifies them as INVALID rather than UNKNOWN
disabled cycleway quest
added cycleway=shoulder option for overlay and quest (see discussion)
sidewalk overlay: do not show missing sidewalks on roads with a speed limit <= 10 km/h and unpaved roads as missing
sidewalk overlay: show sidewalks mapped on cycleways, paths etc
sidewalk overlay: allow editing of sidewalks mapped on exclusive cycleways
sidewalk overlay: prefer tagging sidewalk:both=separate over sidewalk=separate

Features of the overlay

Display and change cycleway layout.

Cycleways behind the curb are blue-ish (a track, a shared sidewalk)
Lanes on the street are yellow-ish
Black is none
Red is missing, invalid or ambiguos.

Display bicycle boulevards, can be selected instead of defining cycleways left and right in countries where they exist legally, see hasBicycleBoulevard.yml

Change the cycleway situation on separately mapped ways and paths.

reverse.mp4

Display and select to reverse the direction of cycleways (functionality also added to respective quest).

This was necessary because the quest could ignore (=not show) roads tagged with such cycleways, while the overlay must support it in order to not overwrite the data with wrong data.

Yes, this very rarely actually happens, see
https://www.openstreetmap.org/way/1032480826
https://www.google.de/maps/@40.6761578,-73.9508024,3a,75y,266.58h,74.83t/data=!3m6!1e1!3m4!1snlCNLeAEszlMGEmNGcfURA!2e0!7i16384!8i8192

This required a large refactor, because the parser that reads the OSM data, the creator that puts the data model back into the tags and all of the display code needs to handle pairs of cycleway type + cycleway direction. Before, it just had to handle the cycleway type.

mostly to hide that complex boolean expression away because it is a little involved to understand

…lists

westnordost · 2022-11-30T15:24:45Z

No, it just claims that both descriptions fit the situation. And this is correct, because the situation can be tagged both ways.

And in case there really is a kerb between sidewalk and cycleway, it is actually a more precise description.

I am kind of surprised that your main line of argumentation seems to come from the point of view that the tagging of one and the same physical situation should be adapted to how things are commonly tagged in a certain region because I do not consider this view as defensible at all in a global project with global tagging scheme.
So far, I thought we'd be on the same page on that general realization.

… if no cycleway=separate etc. is defined

matkoniecz · 2022-11-30T15:39:45Z

I am kind of surprised that your main line of argumentation seems to come from the point of view that the tagging of one and the same physical situation should be adapted to how things are commonly tagged in a certain region because I do not consider this view as defensible at all in a global project with global tagging scheme.
So far, I thought we'd be on the same page on that general realization.

I agree, but I treat sidewalk tagging on cycleway as local aberration not worth promoting, rather than as preferable tagging for this feature.

(maybe it is not justified in this case, but I still cannot bring myself to treat such footway as sidewalk of cycleway while footway and cycleway are together sidewalk of a road)

westnordost · 2022-11-30T15:43:40Z

According to taginfo, about 25000 cycleways have a sidewalk tagged.

matkoniecz · 2022-11-30T15:47:53Z

Out of 2 000 000+ cycleway segments.

https://taginfo.openstreetmap.org/tags/building=collapsed tagging for renderer is used 70 000 times.

westnordost · 2022-11-30T15:50:02Z

Local "aberration" or not, software that processes OSM data needs to support this, doesn't it? StreetComplete cannot come about and just overwrite such cases with segregated=yes and thus destroy data.

westnordost · 2022-11-30T15:55:23Z

Also, looking through the talk pages, sidewalks on cycleways have been brought up before, as early as 2014. It's only in Netherlands etc. where they are actually common but I believe this has nothing to do with local community preference but has to do with that there are actually a number of cycleways which have a sidewalk, i.e. a footway that is segregated from the cycleway with a kerb.

matkoniecz · 2022-11-30T16:51:19Z

Local "aberration" or not, software that processes OSM data needs to support this, doesn't it? StreetComplete cannot come about and just overwrite such cases with segregated=yes and thus destroy data.

I agree, but would it be possible to not show this two as distinct options?

westnordost · 2022-11-30T16:55:09Z

Hmm, that should be possible. You probably mean that however it is tagged, leave it as is if the user does not change the selection and if it is selected newly, always tag it with segregated.

In case you also digged through some past discussion, can you link one where the consensus was something along these lines? (I.e. "eh, no, we do not want sidewalk on cycleways generally even if there are kerbs")

matkoniecz · 2022-11-30T17:01:54Z

You probably mean that however it is tagged, leave it as is if the user does not change the selection and if it is selected newly, always tag it with segregated.

yes - though there is a risk that people in Netherlands are going to be unhappy about that in turn

In case you also digged through some past discussion, can you link one where the consensus was something along these lines? (I.e. "eh, no, we do not want sidewalk on cycleways generally even if there are kerbs")

I can link as many comments to new users asking on Polish Forum/Telegram/Discord how to tag segregated cycleways and noone proposing to tag them as sidewalks. But that may be Poland-specific.

I never really discussed that topic but my first contact with that tagging style was in #3785 where I was completely confused (despite being quite involved in cycleway infrastructure tagging)

Looking at #3785 (comment) it seems to be very Dutch-specific, with segregated=yes as primary tagging style.

matkoniecz · 2022-11-30T17:04:30Z

I can start some review thread if that would be useful.

westnordost · 2022-11-30T17:48:39Z

What is a review thread?

matkoniecz · 2022-11-30T18:06:40Z

Tread on tagging mailing list or this new community site asking people how they would tag such feature and which tagging schemes are in normal use (or accepted) in their area.

westnordost · 2022-11-30T18:08:40Z

Doesn't really matter. "Cycleway with sidewalk" describes accurately a category of ... err bicycle road... in the Netherlands. Hm. This kind of touches on the the "bicycle road" topic I brought up in the forum.

mnalis · 2022-11-30T19:19:17Z

While I can't really provide input on code itself, here is my opinion about this segregated cycleway debate:

if there are multiple schemas to describe some situation, both should be detected when reading the data
unless the user is explicitly making a change, no writing of (e.g. rewritten to other schema) should occur
if user is explicitly making a change, a more common schema should be written.
Alternatively, if it very important not to do it in some country (e.g. if incompatible with Netherlands community mapping practices or something):
- either disable that overlay (or better yet just that problematic answer) in that country only, or
- implement code so alternative schema can be specified per-country

westnordost · 2022-11-30T19:53:16Z

As I wrote before having different tagging in different countries for the same physical thing does not make sense and nothing I want to endorse in this app¹. Different legal concepts and thus different ways to designate something, that's fine. But to have a situation where the same physical thing if boxed into a container and dumped into another country should then be tagged differently is untenable.

¹ It would also be a bottomless pit. Imagine the number of requests in the issue tracker that would be made based on community preference of people in city X to tag Y.

mnalis · 2022-11-30T19:56:02Z

As I wrote before having different tagging in different countries for the same physical thing does not make sense and nothing I want to endorse in this app

I agree. That's why I mentioned it only as a least preferred alternative (i.e. just to note that such possibility exists)

matkoniecz · 2022-11-30T20:58:54Z

app/src/main/res/values/strings.xml

+    <string name="separate_cycleway_non_segregated">Designated combined foot- and cycleway</string>
+    <string name="separate_cycleway_segregated">Segregated cycle- and footway</string>
+    <string name="separate_cycleway_exclusive">Exclusive cycleway</string>
+    <string name="separate_cycleway_with_sidewalk">Exclusive cycleway with sidewalk (footway is segregated from cycleway by a kerb)</string>


Maybe name it "cycleway has a sidewalk for foot traffic"?

So cases where it is clearly cycleway with sidewalk like https://community-cdn.openstreetmap.org/uploads/default/original/2X/0/0e3af26fdddf2ece75e97c6c0ca5c1e549e38273.jpeg from https://community.openstreetmap.org/t/deprecate-key-cyclestreet/6084/42 will be marked with this.

And infrastructure on edge between them, like https://wiki.openstreetmap.org/wiki/File:Witosa_bike_2.jpg will be tagged depending on local preferences (depending on is it considered as segregated footway+cycleway or cycleway with sidewalk)

And cases like https://commons.wikimedia.org/wiki/File:30111VoieVerte1248.JPG will be always tagged as segregated footway and cycleway

Or maybe name it "wide cycleway that has a sidewalk for foot traffic"?

What's wrong with the current string?

Claims/implies that https://wiki.openstreetmap.org/wiki/File:Witosa_bike_2.jpg is mapped incorrectly if tagged

highway=path segregated=yes bicycle=designated foot=designated

Moving in circles here. It does not claim it is mapped incorrectly. "Segregated cycle- and footway" is correct, too.

westnordost · 2022-12-03T13:13:16Z

Another thing that I could add is to not show missing cycleways in 30 zones as missing. Unlike a road with a 30 km/h speed limit which may be roads for through traffic, 30 zones are guaranteed residential and no-through-traffic roads.

Already currently, roads with a speed limit of 20 and below are not shown as missing.

matkoniecz · 2022-12-03T13:18:22Z

Another thing that I could add is to not show missing cycleways in 30 zones as missing.

Definitely makes sense.

Maybe with exception of oneway=yes ones. Maybe only for contraflow side.

westnordost added 30 commits November 15, 2022 20:11

outsource applying cycleway to tags from AddCycleway

c33383b

some refactor

2431ea0

some refactoring

1892349

move getSelectableCycleways logic into Cycleway.kt

78de8ea

disable AddCycleway quest

8893179

fix indentation

d3af1b6

use selectableOrNullValues function

11d4155

SidewalkOverlay: better filter when no sidewalk tagging is expected

7973b6b

add cycleway overlay stub

b5a1c48

remove oneway tagging code from AddCyclewayForm

99b777b

add CyclewayOverlayForm stub

f1ebd53

put isInContraflowOfOneway logic into function

b8b5382

mostly to hide that complex boolean expression away because it is a little involved to understand

move .applyTo functions to own class

5ca9a46

pass geometry to OsmQuest.applyAnswerTo

73d5948

refactor SidewalkCreator (#4634)

e4c7364

reformat

09155d1

remove unused class and file

e34413e

fix tests

e345e4b

redo StreetParkingCreator (fixes #4634)

6742ab0

re-do cyclewaycreator

ffdbb6f

may save selection in street parking overlay

785488a

ask for confirmation when converting road to be also a oneway for cyc…

44f8a14

…lists

try to solve tagging oneway:bicycle

6a93c1f

add a test

db8a61d

more strict parser

feaab13

tag sidewalk again

6956518

more strict cycleway lane parsing

aea20ec

fix tests

53d398c

fix and add test for special case

1fa9480

parse cycleway-segregated-ness of separate paths + tests

c81cfdd

cycleway parser: interpret bicycle=use_sidepath and fall back to that…

96f168f

… if no cycleway=separate etc. is defined

westnordost added 2 commits November 30, 2022 17:07

clearer wording

59fbabc

better wording

09dd761

matkoniecz reviewed Nov 30, 2022

View reviewed changes

westnordost added 5 commits December 3, 2022 14:30

do not show missing cycleway in 30 zones and below as missing

2813568

improve wording

92dfb91

Merge branch 'master' into cycleway-overlay

7ce1020

update changelog

2c34c4d

better wording

3b78130

westnordost merged commit 779bfc7 into master Dec 5, 2022

westnordost mentioned this pull request Dec 5, 2022

Cycleway overlay #4233

Closed

westnordost deleted the cycleway-overlay branch December 27, 2022 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cycleway overlay #4657

Cycleway overlay #4657

westnordost commented Nov 29, 2022 •

edited

Loading

westnordost commented Nov 30, 2022 •

edited

Loading

matkoniecz commented Nov 30, 2022 •

edited

Loading

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022 •

edited

Loading

westnordost commented Nov 30, 2022

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022 •

edited

Loading

matkoniecz commented Nov 30, 2022

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022

westnordost commented Nov 30, 2022

mnalis commented Nov 30, 2022

westnordost commented Nov 30, 2022 •

edited

Loading

mnalis commented Nov 30, 2022

matkoniecz Nov 30, 2022 •

edited

Loading

westnordost Dec 3, 2022

matkoniecz Dec 3, 2022

westnordost Dec 3, 2022

westnordost commented Dec 3, 2022

matkoniecz commented Dec 3, 2022 •

edited

Loading

Cycleway overlay #4657

Cycleway overlay #4657

Conversation

westnordost commented Nov 29, 2022 • edited Loading

Features of the overlay

westnordost commented Nov 30, 2022 • edited Loading

matkoniecz commented Nov 30, 2022 • edited Loading

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022 • edited Loading

westnordost commented Nov 30, 2022

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022 • edited Loading

matkoniecz commented Nov 30, 2022

westnordost commented Nov 30, 2022

matkoniecz commented Nov 30, 2022

westnordost commented Nov 30, 2022

mnalis commented Nov 30, 2022

westnordost commented Nov 30, 2022 • edited Loading

mnalis commented Nov 30, 2022

matkoniecz Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

westnordost Dec 3, 2022

Choose a reason for hiding this comment

matkoniecz Dec 3, 2022

Choose a reason for hiding this comment

westnordost Dec 3, 2022

Choose a reason for hiding this comment

westnordost commented Dec 3, 2022

matkoniecz commented Dec 3, 2022 • edited Loading

westnordost commented Nov 29, 2022 •

edited

Loading

westnordost commented Nov 30, 2022 •

edited

Loading

matkoniecz commented Nov 30, 2022 •

edited

Loading

matkoniecz commented Nov 30, 2022 •

edited

Loading

matkoniecz commented Nov 30, 2022 •

edited

Loading

westnordost commented Nov 30, 2022 •

edited

Loading

matkoniecz Nov 30, 2022 •

edited

Loading

matkoniecz commented Dec 3, 2022 •

edited

Loading