Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pivot point in StreetParkingDrawable #4600

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix pivot point in StreetParkingDrawable #4600

merged 1 commit into from
Nov 2, 2022

Conversation

tapetis
Copy link
Contributor

@tapetis tapetis commented Nov 2, 2022

Closes #4590 (sorry).

Before my changes in 99be3a9, the car illustrations were shown correctly, but some cars were clipped when editing in a country with left-handed traffic:

After my changes in 99be3a9, the pivot point for the Canvas rotation / scaling was incorrect and the illustrations were not shown correctly:

With this PR both issues are fixed:

I tested my changes both with left-handed and right-handed traffic and did not notice any new issues.

@westnordost
Copy link
Member

Noice!

So I understand there was a bug in the first place but it didn't show because the drawable always painted itself 2x as many times as necessary and you solved the root issue, thank you!

@westnordost
Copy link
Member

Since the drawable is also shown in the street side select puzzle: Did you test if it shows correctly both in left-hand and right-hand driving countries there as well?

@tapetis
Copy link
Contributor Author

tapetis commented Nov 2, 2022

Yes, the orientation dialog, position dialog, and the puzzle all looked good. I hope I didn't miss anything this time 🙈.

@westnordost westnordost merged commit 2d185b9 into streetcomplete:master Nov 2, 2022
@tapetis tapetis deleted the fix-left-hand-parking-images branch November 2, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: thumbnails not shown in street parking overlay
2 participants