New quest ref for emergency access points #4386

mcliquid · 2022-09-16T22:40:22Z

New Quest: "add ref" for (highway = emergency_access_point or emergency = access_point) and !name and !ref and noref != yes and ref:signed != no and !~"ref:.*"
Added quest icon
Add Option to Delete
Add other Answer "Is Assembly Point"
- Remove highway-Tag if set

Duplicated quest files from BusStopRef quest.

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt

matkoniecz

Please, add authorship info to https://github.com/streetcomplete/StreetComplete/blob/master/res/graphics/authors.txt#L255 (unless icon is placeholder and @westnordost will make a new one)

Also, for icon I suspect that inner "Emergency" can be removed to simplify it and make it more multilanguage-friendly (and making separate icon for each language is not a good idea :) )

matkoniecz · 2022-09-17T12:55:29Z

In general: congratulations and thanks for submission! This quest is a bit borderline with relatively low usage but it fixes something validly reported as a problem by QA tool and requiring in-place survey and adding quest to more remote areas which are a bit quest-starved right now.

westnordost

The "Emergency" should be deleted from the icon. It is too small

app/src/main/java/de/westnordost/streetcomplete/quests/QuestsModule.kt

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt

...src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRefForm.kt

app/src/main/res/values/strings.xml

https://github.com/streetcomplete/StreetComplete/pull/4386/files/1d00d691f63ad6f63772a0bb0f9082efbd2d14a7#r973587434

…ints

…mcliquid/StreetComplete into new-quest-ref-for-access-points

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt

res/graphics/authors.txt

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt

mcliquid · 2022-09-23T19:00:31Z

@Helium314 Unfortunately, I have to capitulate on the implementation of the image for the answer "Assembly Point". The Quest is from my point of view so far ready, but I just can't get the ImageView into the layout. I am not yet so deeply deved into Java. :(
Would you be interested in taking over?

westnordost · 2022-09-23T19:33:09Z

But then this PR wouldn't be yours anymore. I added a hint how to do it in the comment, maybe this will help you.

@peternewman

Thanks @peternewman for the input.

…ints

app/src/main/res/values/strings.xml

app/src/main/res/layout/dialog_confirm_assembly_point.xml

app/src/main/res/drawable/ic_assembly_point.xml

...src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRefForm.kt

Co-authored-by: Tobias Zwick <newton@westnordost.de>

…ints

…mcliquid/StreetComplete into new-quest-ref-for-access-points

mcliquid · 2022-09-25T18:32:24Z

Thank you for all your help! I'm really thankful for that.

I've updated the PR according to your feedback and attached some screenshots of the functionallity.
I would declare this PR as "ready for publish".

Screenshots:
https://user-images.githubusercontent.com/3351668/192159389-8c25f36c-7a85-443e-82d7-cce155e27fb0.png
https://user-images.githubusercontent.com/3351668/192159392-9a8e0b09-6a84-461e-8c7d-b78abb34fcf5.png
https://user-images.githubusercontent.com/3351668/192159393-9865e7a1-a28e-435e-80e4-b90899b440a6.png

westnordost

Looks good now, just one thing

...src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRefForm.kt

westnordost · 2022-09-25T18:35:23Z

https://user-images.githubusercontent.com/3351668/192159392-9a8e0b09-6a84-461e-8c7d-b78abb34fcf5.png

"An emergency [...] is where people assemble in case of an emergency" sounds doppelt-gemoppelt. How about leaving out the first "emergency"? Would be more consistent with the other string, too.

Also, I am not sure if it is necessary to display the assembly point picture in such a huge size. On the other hand, I guess it can't hurt, I guess? (It looks like the size of the image makes the size of the dialog stretch out to its maximum dimensions)

mcliquid · 2022-09-25T18:55:56Z

Is it okay to give the graphic a width like "200p", or is that problematic for other resolutions?

...src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRefForm.kt

HolgerJeromin · 2022-09-25T20:40:47Z

The screenshot shows "highway milestone".
Is that a bug?

mcliquid · 2022-09-26T06:09:16Z

The screenshot shows "highway milestone". Is that a bug?

No, it's tagged wrong / doubled. See https://www.openstreetmap.org/node/273208408

mcliquid added 13 commits September 16, 2022 18:55

duplicate folder with quest of a similar design

ef3f3a9

Duplicated quest files from BusStopRef quest.

add to QuestsModule

c76aa6d

Add quest string

bd2bb2b

Shorten question and add other answer

2d3b768

Add name to filter

5657a2d

Add access_point.svg as quest icon

3b62e2f

Cleaned the quest icon a little bit

4d89c77

Add drawable icon

db89744

Cleaned unused things and added icon

f6bfcc6

Add DeleteElement

576e1ff

Add "Other Answer": "It's an Assembly Point"

f4c0fb9

Removed "emergency = assembly_point" from filter (was not intended)

002e7d2

Remove highway tag only when emergency_access_point

1d00d69

matkoniecz reviewed Sep 17, 2022

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt Outdated Show resolved Hide resolved

matkoniecz requested changes Sep 17, 2022

View reviewed changes

westnordost requested changes Sep 17, 2022

View reviewed changes

westnordost and others added 12 commits September 17, 2022 15:50

remove unnecessary brackets

facdc3a

add to "RARE" achievement

8eab9da

Moved the quest up to AddPostboxRef

fd7c9fc

https://github.com/streetcomplete/StreetComplete/pull/4386/files/1d00d691f63ad6f63772a0bb0f9082efbd2d14a7#r973587434

Change wording

1631f32

Remove text from quest icon

c87804e

use nonBlankTextOrNull

53e609d

use nonBlankTextOrNull

91c9db6

Merge branch 'streetcomplete:master' into new-quest-ref-for-access-po…

08f4fec

…ints

Fixed wording

0ad3a1c

always offer other answer option

2051f6a

Merge branch 'new-quest-ref-for-access-points' of https://github.com/…

a4ac8c4

…mcliquid/StreetComplete into new-quest-ref-for-access-points

Created icon from scratch due to bad license

30450f4

mcliquid requested a review from matkoniecz September 18, 2022 15:24

peternewman reviewed Sep 18, 2022

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt Show resolved Hide resolved

peternewman reviewed Sep 18, 2022

View reviewed changes

res/graphics/authors.txt Show resolved Hide resolved

peternewman reviewed Sep 19, 2022

View reviewed changes

app/src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRef.kt Outdated Show resolved Hide resolved

mcliquid added 6 commits September 23, 2022 22:25

Added assembly_point.svg

7a90cd0

Create confirmation dialog

f9cf321

Add View and String

573a01c

Changed noref to ref:signed

a2cccad

Thanks @peternewman for the input.

Changed wikiLink

4157c44

Merge branch 'streetcomplete:master' into new-quest-ref-for-access-po…

62112ab

…ints

westnordost reviewed Sep 24, 2022

View reviewed changes

westnordost and others added 6 commits September 24, 2022 18:41

remove fillType=evenOdd

253de55

fix picture does not show

95da252

Update app/src/main/res/values/strings.xml

461b7e1

Co-authored-by: Tobias Zwick <newton@westnordost.de>

Merge branch 'streetcomplete:master' into new-quest-ref-for-access-po…

b22ec59

…ints

Removed extra function

af08529

Merge branch 'new-quest-ref-for-access-points' of https://github.com/…

86072b3

…mcliquid/StreetComplete into new-quest-ref-for-access-points

westnordost requested changes Sep 25, 2022

View reviewed changes

...src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRefForm.kt Outdated Show resolved Hide resolved

Reduced image size of assembly icon

cbdf467

westnordost approved these changes Sep 25, 2022

View reviewed changes

westnordost reviewed Sep 25, 2022

View reviewed changes

...src/main/java/de/westnordost/streetcomplete/quests/access_point_ref/AddAccessPointRefForm.kt Outdated Show resolved Hide resolved

fix function name

03ccf4c

westnordost merged commit e8fe3c7 into streetcomplete:master Sep 28, 2022

mcliquid deleted the new-quest-ref-for-access-points branch September 29, 2022 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New quest ref for emergency access points #4386

New quest ref for emergency access points #4386

mcliquid commented Sep 16, 2022 •

edited

Loading

matkoniecz left a comment •

edited

Loading

matkoniecz commented Sep 17, 2022

westnordost left a comment

mcliquid commented Sep 23, 2022

westnordost commented Sep 23, 2022 •

edited

Loading

mcliquid commented Sep 25, 2022

westnordost left a comment

westnordost commented Sep 25, 2022 •

edited

Loading

mcliquid commented Sep 25, 2022 •

edited

Loading

HolgerJeromin commented Sep 25, 2022

mcliquid commented Sep 26, 2022

New quest ref for emergency access points #4386

New quest ref for emergency access points #4386

Conversation

mcliquid commented Sep 16, 2022 • edited Loading

matkoniecz left a comment • edited Loading

Choose a reason for hiding this comment

matkoniecz commented Sep 17, 2022

westnordost left a comment

Choose a reason for hiding this comment

mcliquid commented Sep 23, 2022

westnordost commented Sep 23, 2022 • edited Loading

mcliquid commented Sep 25, 2022

westnordost left a comment

Choose a reason for hiding this comment

westnordost commented Sep 25, 2022 • edited Loading

mcliquid commented Sep 25, 2022 • edited Loading

HolgerJeromin commented Sep 25, 2022

mcliquid commented Sep 26, 2022

mcliquid commented Sep 16, 2022 •

edited

Loading

matkoniecz left a comment •

edited

Loading

westnordost commented Sep 23, 2022 •

edited

Loading

westnordost commented Sep 25, 2022 •

edited

Loading

mcliquid commented Sep 25, 2022 •

edited

Loading