Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AddProhibitedForPedestrians quest in Sweden #3195

Closed

Conversation

riiga
Copy link

@riiga riiga commented Aug 20, 2021

After using StreetComplete for a while now and having already changed the Swedish translation to specify the AddProhibitedForPedestrians only applies to legal prohibitions, this quest still causes issues.

  1. There's still foot=no being added in error, mostly by people not using the Swedish localisation (Having your phone or computer set to English is common among more tech-savvy people). It's not a worthwhile enterprise to try and contact those users nor is it possible to force them to use a localised version of the app.
  2. Roads (in Sweden) where pedestrians are prohibited and which are not already covered by other regulations such as motorways are very uncommon.
  3. The biggest issue is not actually adding foot=no in error, it's adding foot=yes if pedestrians are allowed. By default foot=yes is implied for all roads, streets, paths, etc. in Sweden, except motorways, expressways (motorroad=yes) and explicit cycleways. Unlike countries like the UK, there is no legal "right of way" that can be restricted and for which adding foot=yes is useful.

@@ -34,6 +34,8 @@ class AddProhibitedForPedestrians : OsmFilterQuestType<ProhibitedForPedestriansA
override val icon = R.drawable.ic_quest_no_pedestrians
override val isSplitWayEnabled = true

override val enabledInCountries = AllCountriesExcept("SE")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to import de.westnordost.streetcomplete.data.quest.AllCountriesExcept for this to work

@westnordost
Copy link
Member

Translation was changed from
"Är fotgängare förbjudna att gå på den här vägen?"
to
"Finns det ett skyltat förbud att gå på den här vägen?"
on the 2nd of May 2021.

The issue this PR refers to is #2472.

I closed the issue because there was no reply / suggestion after my last comment.

At this point, I still think there can't be a Swedish solution for that.

Either we can make this quest not being misunderstood better, or maybe the whole quest should be removed if this is not possible. For the sake of keeping it in order, I will reopen #2472 and ask everyone to contribute to that ticket and close this PR (because a Sweden-only solution will not be implemented, as this is an issue that is independent of the country).

@westnordost
Copy link
Member

Oh, I never closed #2472. So anyway, please respond there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants