Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile screen: Number 1 local rank for latest week does not have full wreath #4762

Closed
arrival-spring opened this issue Jan 24, 2023 · 3 comments
Assignees
Labels

Comments

@arrival-spring
Copy link
Contributor

How to Reproduce
Be ranked first locally for the past week.

Expected Behavior
Rank 1 (and other high ranks) show full wreath

Versions affected
50.2

I am not sure what rank should require a full wreath for local rank, but I feel like number 1 definitely should have it.

The problem seems to be around here:

The rank is surely always >=1 so this can never be 100?

Ping @matkoniecz

@matkoniecz matkoniecz self-assigned this Jan 24, 2023
@matkoniecz
Copy link
Member

matkoniecz commented Jan 26, 2023

Thanks for noticing, reporting and even diagnosing!

screen10

matkoniecz added a commit that referenced this issue Jan 26, 2023
adjustment triggered by #4762
@arrival-spring
Copy link
Contributor Author

Just got the beta update and now all my wreaths are full! Thanks for fixing this!

@matkoniecz
Copy link
Member

Nice to see that someone cares about them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants