Notes being questions are not displayed as quests

[Strubbl]

How to Reproduce
Open SC and go to e.g. this area: https://www.openstreetmap.org/#map=19/48.10945/11.72678&layers=N
The two notes, which are currently open there, contain a ?. Both are not displayed as quests when the option to show notes not phrased as a question is disabled.

Expected Behavior
I see the notes as a quest and can add a comment or photo comment there.

Versions affected
v47.1

(After comment #4482 (comment), this issue has been edited in order to be precise about the option to show notes not phrased as a question)

[Helium314]

Do you have the option to show notes not phrased as a question enabled?

[Strubbl]

Thank you for the pointer. You are right. This was disabled. Had the settings been reset? I am not aware that i disabled this setting. I always had that on.

[FloEdelmann]

But shouldn't it be asked anyway, because the note text actually contains a ??

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt

Lines 224 to 242 in b0eb766

	private fun Note.probablyContainsQuestion(): Boolean {
	/* from left to right (if smartass IntelliJ wouldn't mess up left-to-right):
	- latin question mark
	- greek question mark (a different character than semikolon, though same appearance)
	- semikolon (often used instead of proper greek question mark)
	- mirrored question mark (used in script written from right to left, like Arabic)
	- armenian question mark
	- ethopian question mark
	- full width question mark (often used in modern Chinese / Japanese)
	(Source: https://en.wikipedia.org/wiki/Question_mark)
	NOTE: some languages, like Thai, do not use any question mark, so this would be more
	difficult to determine.
	*/
	val questionMarksAroundTheWorld = "[?;;؟՞፧？]"
	val text = comments.firstOrNull()?.text
	return text?.matches(".*$questionMarksAroundTheWorld.*".toRegex()) ?: false
	}

[Strubbl]

Valid point. Both texts of the notes contain a ?. I am going to re-word my original post to match this.

[mnalis]

More importantly, Show all notes, even when checked, will not actually show all notes.
Most notably, it will not show your own new notes:

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt

Lines 208 to 210 in b0eb766

	/* newly created notes by user should not be shown if it was both created in this app and has no
	replies yet */
	if (probablyCreatedByUserInThisApp(userId) && !hasReplies) return false

I've suggested to implement an option to allow user to view his own notes before (#2692) but it has sadly been rejected.

[Strubbl]

@mnalis thank you. I guess this is off-topic of this issue.