-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest focus-ring appears shifted. #1810
Comments
It's fixed, just not released yet. |
If you rotate the map, does the selection ring "wander" or does it stay at the same position relatively to the pin? |
Always the same relative position (slightly below, slightly left). |
What's your device? Specifically, what is the DPI of your device? |
Device is a Samsung Galaxy S6, specifically the SM-G920A. xxxhdpi, if that's what you were looking for (edit: this was surprisingly hard to find; I ended up just adding code to find it like this: https://stackoverflow.com/questions/3166501/getting-the-screen-density-programmatically-in-android -- so now it's easy for me to get any other screen info you might want) |
Ok, then it is likely a problem with tangram-es which apparently treats pixel offsets for elements in layers differently than for markers. I can reproduce it on a xxxhdpi emulator. On a hdpi device, the circle offsets slightly to the right. Though, the backlog of bugs I reported in tangram-es is already so full, I kind of don't want to add even more there as long as the others are not fixed. Partly because I will have to research the exact problem myself as well and create a minimal example. Perhaps someone else would like to do that and report the exact problem? Setup would be a map data layer consisting of a single dot at a certain position and a map marker at the same position, then, add a certain same offset for both in the style. |
My density is: 1440 x 2560 pixels, 16:9 ratio (~538 ppi density). I cannot convert that to '*hdpi' units like smichel17. Same behaviour as he describes, offset is constant under rotation. Does the tangram issue also explain, why the pin is is not exactly on the steps? Its position also changes under rotation (probably rotating around the point it should be contantly point to) |
Maybe |
I'm not really a fan of pixel peaking on rendering libraries, but I can confirm a very slightly wrong position of the pins. It's around 10% of the pin size too far down, and stay too far down on the rotation. But the ring stays where it should be in my case. Android 9 |
Thank you for the input! What is the "display width" setting? |
Display size (I assume you mean this) is found in display and accessibility settings (at least in all versions of Lineage OS I used), and basically changes the size of text and icons. Why it has such a confusing name I don't know. |
Ok I'd say it simulates a different DPI. |
Actually, where are quest marker (bottom/tip) and dot supposed to be located? |
So is the pin the one thing that is shifted and not the selection ring?
Am 9. Juli 2020 09:27:02 MESZ schrieb Helium314 <notifications@github.com>:
…Actually, where are quest marker (bottom/tip) and dot supposed to be
located?
The dot always seems to be higher than the quest location (especially
visible at low zoom levels)
The marker is too high for me and seems to be too low for others, see
#1810 (comment)
|
I think it's both. When reading https://developer.android.com/training/multiscreen/screendensities#TaskUseDP it might be that the distances are defined in px, but the sizes are in dp. |
That's good information. I think we collected enough info now to make a reasonable bug report. I think the source may be that actually the offsets given in the style are not adjusted at all for different DPIs. |
- fixes workarounded crash (tangrams/tangram-es#2136) - fixes misplacement of quest ring #1810 (and quest pins) - fixes workarounded crash on Android API 30 #2336 (tangrams/tangram-es#2215)
- fixes workarounded crash (tangrams/tangram-es#2136) - fixes misplacement of quest ring #1810 (and quest pins) - fixes workarounded crash on Android API 30 #2336 (tangrams/tangram-es#2215)
was fixed already in v30 |
How to Reproduce
It happens for every quest type. I tried complete reinstall, still appears shifted
Versions affected
v19 (fDroid)
Android 6.0
LG G4 H815
The text was updated successfully, but these errors were encountered: