Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [ETH-811] Fix crashing Solidity compiler download #951

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Jan 16, 2025

Changes

Bumped NodeJS minor version.

Background

There has been a bugfix in the NodeJS v18.18 (nodejs/node#48435) so that it works better with the undici library (nodejs/undici#2173). That library is used by Harhat internally, e.g. when it downloads Solidity compilers.

The bug caused compiler downloads (https://github.com/NomicFoundation/hardhat/blob/40673c6ff9742898920d0e92ccd630e1a685b434/packages/hardhat-core/src/internal/util/download.ts#L23) to crash the hardhat compile task. There was no visible error message from that crash.

As the compilation terminated, the next CI phase (tsc -p tsconfig.build.json in build.sh) failed. These kind of error messages were shown:

Error: src/exports.ts(1,66): error TS2307: Cannot find module '../artifacts/contracts/OperatorTokenomics/Operator.sol/Operator.json' or its corresponding type declarations.

@teogeb teogeb changed the title build: Bump NodeJS minor version test: Fix crashing Solidity compiler download Jan 16, 2025
@teogeb teogeb changed the title test: Fix crashing Solidity compiler download test: [ETH-811] Fix crashing Solidity compiler download Jan 16, 2025
Copy link

linear bot commented Jan 16, 2025

@teogeb teogeb requested a review from jtakalai January 16, 2025 15:40
@jtakalai jtakalai merged commit a07dd87 into master Jan 16, 2025
3 checks passed
@jtakalai jtakalai deleted the bump-node-minor-version branch January 16, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants