Nwjs upgrade #615
Merged
Nwjs upgrade #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 83.79% 83.73% -0.07%
==========================================
Files 479 479
Lines 13527 13537 +10
Branches 1224 1226 +2
==========================================
Hits 11335 11335
- Misses 2098 2108 +10
Partials 94 94 |
bastimeyer
force-pushed
the
nwjs-upgrade
branch
3 times, most recently
from
5987b35
to
99cdf36
Compare
Somehow NW.js/Chromium doesn't like overflow:hidden being set on the document body anymore and the parent wrapper element of the main content element needs to have this property set.
And use proper initial timestamps for requestAnimationFrame callbacks
instead of making a second runtime evaluation over the CDP
bastimeyer
force-pushed
the
nwjs-upgrade
branch
from
99cdf36
to
38525b8
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before building the app, please back up your
streamlink-twitch-gui{,-test}config folder(s), so that you're able to downgrade later on again if you need to.Checklist
This is caused by an improperly implemented workaround in Chromium (https://crbug.com/804637) which made it into this NW.js release. Has been fixed just recently and will land in NW.js hopefully soon.
nw-buildersometimes fails while downloading the new NW.js release archivesDidn't happen again, must have been an issue with the servers.
Minor breaking changes
start.shwrapper script on Linux.If you're running Streamlink Twitch GUI from the Linux tarballs, you'll have to run
remove-menuitems.shonce before upgrading and runadd-menuitems.shafter upgrading for setting up a new menu shortcut. This change is not tied to the NW.js upgrade, but was overdue a long time ago. The available Linux packages won't be affected on the next release, as they include properly packaged menu shortcuts.Why is Github still showing the wrong commit order after my forced branch pushes? Not that it matters, but...